%selkey cannot specify characters that needs shift key to access

[sltam]

I have these config in my .cin file:

%gen_inp
...
%selkey !@#$%^&*()
...
%keyname begin
...

When I put this cin file into OpenVanilla 1.0.x, and type anything that has disambiguation, it shows !, @, etc. on top of the choices, but when I hit shift-1, shift-2, etc. OpenVanilla unexpectedly cancels the current composition and emits the ! character! This renders my input method completely unusable!

This does not happen to OpenVanilla 0.8.x.

Before:

After hitting "!":

[sltam]

Note that this issue is almost non-existent for cin files shipped with OpenVanilla, because they almost avoided %selkey of characters on the upper row of an en-us keyboard.

$ grep selkey openvanilla-1.0/DataTables/*.cin | grep -v 123456789
openvanilla-1.0/DataTables/array26.cin:%selkey 1234
openvanilla-1.0/DataTables/array40.cin:%selkey '[]-="{}_
openvanilla-1.0/DataTables/dayi3-patched.cin:%selkey '[]-\67890
openvanilla-1.0/DataTables/dayi3.cin:%selkey '[]-\6789
openvanilla-1.0/DataTables/lookup-poj.cin:%selkey asdfghjkl;
openvanilla-1.0/DataTables/poj-holo.cin:%selkey asdfghjkl;

Except 行列40, so here is a test case for it. Type: 8 =. You see this:

Hit ". You expect to get ㄊ but you get " instead.

[ghost]

Have anyone been able to fix this?

Or does anyone know where to edit in the code to change this?

[sltam]

@etang77 My guess is OVInputMethodController::handleOVKey expecting OVOneDimensionalCandidatePanelImpl::handleKey to return CandidateSelected but it doesn't. It could be as simple as OVInputMethodController::handleEvent sending the wrong OVKey to handleOVKey as this function has plenty of key conversion logic.

Since I am not affiliated to this project, I don't know how to start helping. I can't even get my self-compiled library to run locally yet.

[ghost]

I've seen that assocation phrases has in its script, allow to use Shift + Symbols as select key, and display as an "Up arrow 1". I'm sure it can work for the normal select key too, anyone can teach me how to edit?

[lukhnos]

@sltam @etang77 If you use Xcode, could you try building the target "OpenVanillaInstaller" in the latest master (open OpenVanilla.xcodeproj in the repo root), and use the installer to install a dev version (1.3.2-dev) on your machine? The commit should fix this long-standing issue. Thanks!

[ghost]

Thank you, so so so so much! Everything fixed (I think)!

[ghost]

Being greedy here. Is it possible for the interface to show "Shift1"、"Shift2" like in Associated Phrase?