Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to link to a validation result in the web interface #596

Closed
ifokkema opened this issue Mar 25, 2024 · 21 comments
Closed

Add a method to link to a validation result in the web interface #596

ifokkema opened this issue Mar 25, 2024 · 21 comments

Comments

@ifokkema
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
I would like to send a link to a colleague that shows a validation result of a variant. I could send a link to the REST API, but that is just useful for bioinformaticians. I would like to have a link to the result on the web interface.

Describe the solution you'd like
There are two possible options that I see:

  • Change the URL when a variant has been submitted so I can copy that, and let VV process the variant in the URL when the link is pasted into the browser address bar.
  • Have the current interface generate a link and allow the user to copy it, e.g., "Copy link to this result page", or "Share this validation result", and add a simple interface that will accept that link, take the input from the URL, and submit the normal web interface form.

Describe alternatives you've considered
The API is the only current option that I know, that I can link to. The output, however, is only useful for bioinformaticians.

@leicray
Copy link
Contributor

leicray commented Mar 26, 2024

You have my full support for this feature request. I have often had exactly the same thoughts.

@ifokkema
Copy link
Collaborator Author

@leicray Mutalyzer has this option, and it's been really useful in the past. It would actually help promote VV, as we can just link to validation results as examples of specific issues.

@Peter-J-Freeman
Copy link
Collaborator

@leicray we have this no? It's what Alamut visual uses. Need to look it up?

@Peter-J-Freeman
Copy link
Collaborator

You have my full support for this feature request. I have often had exactly the same thoughts.
Can you look at the URL Alamut visual puts together @leicray . Thats the method!!!!

@leicray
Copy link
Contributor

leicray commented Apr 16, 2024 via email

@Peter-J-Freeman
Copy link
Collaborator

but the URL they used is what we need

I will see if I can dig it out in my email trails

@Peter-J-Freeman
Copy link
Collaborator

The best we can do is a URL like

https://variantvalidator.org/service/validate/?variant=NM_000088.3:c.589G%3ET&transcripts=mane

The user then needs to select the genome build and hit submit.

It was not my design decision and I do not fully understand it, but it has somethign to do with running on AJAX

@Peter-J-Freeman
Copy link
Collaborator

Correction we can do

https://variantvalidator.org/service/validate/?variant=NM_000088.3:c.589G%3ET&transcripts=mane&genomebuild=GRCh37

Then the user just needs to hit Submit.

I'm seeing if there is an autosubmit option

@Peter-J-Freeman
Copy link
Collaborator

So, it looks like I could build in an autosubmit feature into the website. Don;t have time right now, but @ifokkema and @leicray , the URL above completes this request for now and I will update here once I get (if I can get) the autosubmit to work

@Peter-J-Freeman
Copy link
Collaborator

@Peter-J-Freeman
Copy link
Collaborator

is this what is requested @ifokkema and @leicray

@ifokkema
Copy link
Collaborator Author

Nice! If it auto-submits, that would be great, indeed!
Then, we need to get that link from the page somehow, e.g., by a "share this result" button or something similar. Otherwise, it would be up to the user to know the URL to use to share that specific result.

@Peter-J-Freeman
Copy link
Collaborator

@ifokkema. The auto submit works, I just need to complete a fiull release cycle and sadly the VV interface is the bottom of the list to make the flow correct. Hope by end of May.

@ifokkema
Copy link
Collaborator Author

No worries! It would be great to have this working, but there is no rush! I am finishing off some stuff that has been occupying my brain for too long and will continue working on the LOVD/VV interaction end of this month or May.

@Peter-J-Freeman
Copy link
Collaborator

Great. @John-F-Wagstaff. We need to open an issue to keep track of the things we need to do for @ifokkema. Can you please open the issue and log progress.

I think there are a couple open e.g. #582

@Peter-J-Freeman
Copy link
Collaborator

@ifokkema you can include links like https://variantvalidator.org/service/validate/?variant=NM_000088.3:c.589G%3ET&transcripts=mane&genomebuild=GRCh37&autosubmit=true straight away, but the auto submit will just not work until the update, but it will save you needing to re-code

@Peter-J-Freeman
Copy link
Collaborator

also @ifokkema would you like me to build the call into the REST API ouptut?

@ifokkema
Copy link
Collaborator Author

@ifokkema you can include links like https://variantvalidator.org/service/validate/?variant=NM_000088.3:c.589G%3ET&transcripts=mane&genomebuild=GRCh37&autosubmit=true straight away, but the auto submit will just not work until the update, but it will save you needing to re-code

Beautiful, thanks a lot!

also @ifokkema would you like me to build the call into the REST API ouptut?

That's actually a very nice idea - that way, whenever the URL changes on your side, you'd just have to update the API and my code does not need to contain a hardcoded URL but instead can just use whatever the API returns. I will then also be able to link to the VV results from my HGVS syntax checker interface!

@Peter-J-Freeman
Copy link
Collaborator

@ifokkema . Great, will do. @John-F-Wagstaff , another point to add to the LOVD roadmap

@Peter-J-Freeman
Copy link
Collaborator

@leicray @ifokkema Is this now working. Can I close?

@leicray
Copy link
Contributor

leicray commented May 1, 2024

Yes, this does work for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants