Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed prediction label assignment for OpenVINO inferencer #1872

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Changed prediction label assignment for OpenVINO inferencer #1872

merged 3 commits into from
Mar 25, 2024

Conversation

TurboJonte
Copy link
Contributor

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

📝 Description

  • Provide a clear summary of the changes and the issue that has been addressed.
  • 🛠️ Fixes # (issue number)

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

@TurboJonte
Update openvino_inferencer.py
1b056bb 
Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py
@TurboJonte TurboJonte marked this pull request as draft March 18, 2024 22:12
@TurboJonte TurboJonte changed the title Update openvino_inferencer.py Changed prediction label assignment for OpenVINO inferencer Mar 18, 2024
@TurboJonte TurboJonte marked this pull request as ready for review March 18, 2024 22:14
@TurboJonte TurboJonte mentioned this pull request Mar 20, 2024
Merged
9 tasks
samet-akcay
samet-akcay approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@samet-akcay samet-akcay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contribution!

@samet-akcay samet-akcay added this to the v1.1.0 milestone Mar 25, 2024
@samet-akcay samet-akcay merged commit 6be4c80 into openvinotoolkit:main Mar 25, 2024
6 of 7 checks passed
samet-akcay added a commit that referenced this pull request Mar 26, 2024
@samet-akcay @AlexanderDokuchaev @TurboJonte
🔒 Bump onnx version as the previous version caused security issues (#…
bca285e 
…1907)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Bump onnx version as the previous version caused security issues

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
samet-akcay added a commit that referenced this pull request Mar 26, 2024
@Bepitic @AlexanderDokuchaev
@samet-akcay @TurboJonte @djdameln
Add: fix image transform to float (#1902)
9b78034 
* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Add: fix image transform to float

Signed-off-by: Bepitic <bepitic@gmail.com>

* upd: video dtpe transform from torchvision

Signed-off-by: Bepitic <bepitic@gmail.com>

* Added the scale.

Signed-off-by: Bepitic <bepitic@gmail.com>

* Update src/anomalib/data/base/video.py

Co-authored-by: Dick Ameln <amelndjd@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>
samet-akcay added a commit that referenced this pull request Mar 27, 2024
@samet-akcay @djdameln
@AlexanderDokuchaev @TurboJonte @Bepitic @ashwinvaidya17
Merge v1.0.1 to main (#1905)
e35b574 
* Update CHANGELOG.md (#1899)

* Update __init__.py

* Fix metric bug (#1900)

* check metrics by name instead of key

* remove prefix from temp metric collection

* 🔒 Bump onnx version as the previous version caused security issues (#1907)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Bump onnx version as the previous version caused security issues

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>

* Add: fix image transform to float (#1902)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Add: fix image transform to float

Signed-off-by: Bepitic <bepitic@gmail.com>

* upd: video dtpe transform from torchvision

Signed-off-by: Bepitic <bepitic@gmail.com>

* Added the scale.

Signed-off-by: Bepitic <bepitic@gmail.com>

* Update src/anomalib/data/base/video.py

Co-authored-by: Dick Ameln <amelndjd@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>

* Fix video bug and add tests (#1910)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* squeeze temporal dimension when clip length is 1

* add unit test for video input tensor dtype

* add test for single frame clips

* update changelog

* add author

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Temporarily set devices to 1

* 🐞 Add greyscale conversion (#1911)

Add greyscale conversion

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* 🐞 Fix publish workflow (#1912)

Disable tty prompt for gpg import

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Paco <bepitic@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>
Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 Awaiting requested review from ashwinvaidya17 ashwinvaidya17 is a code owner

@djdameln djdameln Awaiting requested review from djdameln djdameln is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@TurboJonte @samet-akcay