Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix video bug and add tests #1910

Merged
merged 7 commits into from
Mar 26, 2024
Merged

Fix video bug and add tests #1910

merged 7 commits into from
Mar 26, 2024

Conversation

djdameln
Copy link
Contributor

@djdameln djdameln commented Mar 26, 2024 •
edited
Loading

📝 Description

  • Minor bugfix: Squeeze temporal dimension in video inputs when clip length is 1. This is to ensure compatibility of single frame video with image models.
  • Add test case for the above bug
  • Add test case for Add: fix image transform to float #1902

Should be merged after #1902

✨ Changes

Select what type of change your PR is:

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🔨 Refactor (non-breaking change which refactors the code base)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 📚 Documentation update
  • 🔒 Security update

✅ Checklist

Before you submit your pull request, please make sure you have completed the following steps:

  • 📋 I have summarized my changes in the CHANGELOG and followed the guidelines for my type of change (skip for minor changes, documentation updates, and test enhancements).
  • 📚 I have made the necessary updates to the documentation (if applicable).
  • 🧪 I have written tests that support my changes and prove that my fix is effective or my feature works (if applicable).

For more information about code review checklists, see the Code Review Checklist.

AlexanderDokuchaev and others added 4 commits March 25, 2024 11:13
@AlexanderDokuchaev @samet-akcay
📚 Add action to check broken links (openvinotoolkit#1838)
7edb6af 
* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>
@djdameln
squeeze temporal dimension when clip length is 1
b78dca5
@djdameln
add unit test for video input tensor dtype
a0189a6
@djdameln
add test for single frame clips
d52b302
@github-actions github-actions bot added the Tests label Mar 26, 2024
@github-actions github-actions bot added the Docs label Mar 26, 2024
@djdameln djdameln requested a review from yunchu as a code owner March 26, 2024 10:15
@github-actions github-actions bot added Dependencies Pull requests that update a dependency file Setup labels Mar 26, 2024
@djdameln djdameln changed the base branch from main to release/1.0.1 March 26, 2024 10:15
ashwinvaidya17
ashwinvaidya17 approved these changes Mar 26, 2024
View reviewed changes
CHANGELOG.md Outdated
@@ -41,6 +41,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

### Fixed

- 🐞 Fix single-frame video input size (<https://github.com/openvinotoolkit/anomalib/pull/1910>)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to follow the convention, can you add by @djdameln in

@github-actions github-actions bot removed Dependencies Pull requests that update a dependency file Setup labels Mar 26, 2024
@samet-akcay samet-akcay merged commit 335b87c into openvinotoolkit:release/1.0.1 Mar 26, 2024
8 checks passed
samet-akcay added a commit that referenced this pull request Mar 27, 2024
@samet-akcay @djdameln
@AlexanderDokuchaev @TurboJonte @Bepitic @ashwinvaidya17
Merge v1.0.1 to main (#1905)
e35b574 
* Update CHANGELOG.md (#1899)

* Update __init__.py

* Fix metric bug (#1900)

* check metrics by name instead of key

* remove prefix from temp metric collection

* 🔒 Bump onnx version as the previous version caused security issues (#1907)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Bump onnx version as the previous version caused security issues

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>

* Add: fix image transform to float (#1902)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Use LabelName ENUM for label assignment (#1881)

* Use LabelName ENUM for label assignment

* Update src/anomalib/deploy/inferencers/torch_inferencer.py

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Changed prediction label assignment for OpenVINO inferencer (#1872)

* Update openvino_inferencer.py

Fixed incorrect label assignment.
Was True/False, now it's "Anomalous/Normal" as for the PyTorch inferencer in torch_inferencer.py

* Fix ruff

---------

Co-authored-by: Samet <samet.akcay@intel.com>

* Add: fix image transform to float

Signed-off-by: Bepitic <bepitic@gmail.com>

* upd: video dtpe transform from torchvision

Signed-off-by: Bepitic <bepitic@gmail.com>

* Added the scale.

Signed-off-by: Bepitic <bepitic@gmail.com>

* Update src/anomalib/data/base/video.py

Co-authored-by: Dick Ameln <amelndjd@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>

* Fix video bug and add tests (#1910)

* 📚 Add action to check broken links (#1838)

* Fix broken links

* Add link checker

* Fix link in template

* linter

* nightly check

---------

Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* squeeze temporal dimension when clip length is 1

* add unit test for video input tensor dtype

* add test for single frame clips

* update changelog

* add author

---------

Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: Samet Akcay <samet.akcay@intel.com>

* Temporarily set devices to 1

* 🐞 Add greyscale conversion (#1911)

Add greyscale conversion

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

* 🐞 Fix publish workflow (#1912)

Disable tty prompt for gpg import

Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>

---------

Signed-off-by: Bepitic <bepitic@gmail.com>
Signed-off-by: Ashwin Vaidya <ashwinnitinvaidya@gmail.com>
Co-authored-by: Dick Ameln <dick.ameln@intel.com>
Co-authored-by: Alexander Dokuchaev <alexander.dokuchaev@intel.com>
Co-authored-by: TurboJonte <turbojonte@gmail.com>
Co-authored-by: Paco <bepitic@gmail.com>
Co-authored-by: Dick Ameln <amelndjd@gmail.com>
Co-authored-by: Ashwin Vaidya <ashwin.vaidya@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samet-akcay samet-akcay samet-akcay approved these changes

@ashwinvaidya17 ashwinvaidya17 ashwinvaidya17 approved these changes

@yunchu yunchu Awaiting requested review from yunchu

Assignees
No one assigned
Labels
Docs Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@djdameln @ashwinvaidya17 @samet-akcay @AlexanderDokuchaev