Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SAMAutomaticMaskGeneration transform #1168

Merged

Conversation

vinnamkim
Copy link
Contributor

@vinnamkim vinnamkim commented Oct 6, 2023

Summary

  • Same as title
  • Ticket no. 120781.

How to test

Added unit tests for this change and added Jupyter notebook example which can validate this change.

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@vinnamkim vinnamkim added this to the 1.6.0 milestone Oct 6, 2023
@vinnamkim vinnamkim added the FEATURE New feature & functionality label Oct 6, 2023
@vinnamkim vinnamkim marked this pull request as ready for review October 6, 2023 09:41
@vinnamkim vinnamkim requested review from a team as code owners October 6, 2023 09:41
@vinnamkim vinnamkim requested review from jihyeonyi and removed request for a team October 6, 2023 09:41
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
Signed-off-by: Kim, Vinnam <vinnam.kim@intel.com>
@codecov
Copy link

codecov bot commented Oct 6, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (243d721) 80.01% compared to head (0eab5a4) 80.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1168      +/-   ##
===========================================
+ Coverage    80.01%   80.11%   +0.09%     
===========================================
  Files          266      268       +2     
  Lines        29967    30093     +126     
  Branches      5901     5916      +15     
===========================================
+ Hits         23978    24108     +130     
+ Misses        4632     4622      -10     
- Partials      1357     1363       +6     
Flag Coverage Δ
macos-11_Python-3.8 ?
ubuntu-20.04_Python-3.8 80.10% <93.70%> (+0.09%) ⬆️
windows-2019_Python-3.8 80.03% <93.70%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/datumaro/plugins/sam_transforms/__init__.py 100.00% <100.00%> (ø)
...umaro/plugins/sam_transforms/automatic_mask_gen.py 96.36% <96.36%> (ø)
...sam_transforms/interpreters/sam_decoder_for_amg.py 91.42% <91.42%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@wonjuleee wonjuleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@vinnamkim vinnamkim merged commit ba6f0ed into openvinotoolkit:develop Oct 16, 2023
6 checks passed
@yunchu yunchu modified the milestones: 1.6.0, 2.0.0 Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEATURE New feature & functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants