Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dataset formats (cyrilic and spaces in filename) #148

Merged
merged 17 commits into from
Mar 17, 2021
Merged

Fix dataset formats (cyrilic and spaces in filename) #148

merged 17 commits into from
Mar 17, 2021

Conversation

yasakova-anastasia
Copy link

@yasakova-anastasia yasakova-anastasia commented Mar 5, 2021 •
edited

Summary

Resolves openvinotoolkit/cvat#2840
Resolves openvinotoolkit/cvat#2922

  • Added the ability to work with file names containing Cyrillic and spaces

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2020 Intel Corporation
#
# SPDX-License-Identifier: MIT

@zhiltsov-max
Copy link
Contributor

Are any other formats affected? Should we add such tests in all formats?

@yasakova-anastasia yasakova-anastasia changed the title Fix CamVid format dataset Fix dataset formats (cyrilic and spaces in filename) Mar 10, 2021
zhiltsov-max
zhiltsov-max suggested changes Mar 10, 2021
View reviewed changes
datumaro/plugins/camvid_format.py Outdated Show resolved Hide resolved
datumaro/plugins/imagenet_txt_format.py Show resolved Hide resolved
datumaro/plugins/voc_format/converter.py Outdated Show resolved Hide resolved
yasakova-anastasia
yasakova-anastasia commented Mar 15, 2021
View reviewed changes
Copy link
Author

@yasakova-anastasia yasakova-anastasia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

zhiltsov-max
zhiltsov-max previously approved these changes Mar 16, 2021
View reviewed changes
@zhiltsov-max zhiltsov-max merged commit ef12d30 into develop Mar 17, 2021
@yasakova-anastasia yasakova-anastasia deleted the ay/fix-camvid branch March 22, 2021 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhiltsov-max zhiltsov-max zhiltsov-max left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@yasakova-anastasia @zhiltsov-max