Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a pyproject.toml file #671

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Add a pyproject.toml file #671

merged 2 commits into from
Mar 9, 2022

Conversation

IRDonch
Copy link

@IRDonch IRDonch commented Feb 17, 2022

Summary

This file lets the project be built on systems that don't have setuptools or wheel installed. It can also be used as a replacement for tool-specific config files, so merge some of those into it (see the commit message for rationale on why not all config files were merged).

How to test

Checklist

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below)
# Copyright (C) 2021 Intel Corporation
#
# SPDX-License-Identifier: MIT

Roman Donchenko added 2 commits February 17, 2022 13:48
With this, the project can be built on a system that does not have
setuptools or wheel installed.
I like TOML syntax more, and I think it's easier to work with a combined
`pyproject.toml` file than with multiple tiny files.

Note about other configs:

* Bandit supports configuration through `pyproject.toml`, but it requires
  you to supply it explicitly via a command line argument, which is too
  annoying. If they ever fix that, I'd like to merge `.bandit` into
  `pyproject.toml` as well.

* Pylint supports configuration through `pyproject.toml`, but our `.pylintrc`
  is large enough that I think it makes sense to keep it as a separate file.
@zhiltsov-max zhiltsov-max merged commit 6f1f001 into openvinotoolkit:develop Mar 9, 2022
@IRDonch IRDonch deleted the pyproject-toml branch September 9, 2022 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants