Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Arrow format doc #948

Merged
merged 11 commits into from
Apr 19, 2023
Merged

Conversation

cih9088
Copy link
Contributor

@cih9088 cih9088 commented Apr 18, 2023

Summary

Add a doc for arrow format with binary depicted.

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 added the DOC Improvements or additions to documentation label Apr 18, 2023
@cih9088 cih9088 added this to the 1.2.0 milestone Apr 18, 2023
@cih9088 cih9088 requested review from a team as code owners April 18, 2023 07:52
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.02 🎉

Comparison is base (08425db) 78.68% compared to head (10dafb6) 78.70%.

Additional details and impacted files
@@                Coverage Diff                 @@
##           releases/1.2.0     #948      +/-   ##
==================================================
+ Coverage           78.68%   78.70%   +0.02%     
==================================================
  Files                 231      232       +1     
  Lines               26408    26420      +12     
  Branches             5257     5258       +1     
==================================================
+ Hits                20780    20795      +15     
+ Misses               4403     4400       -3     
  Partials             1225     1225              
Flag Coverage Δ
macos-11_Python-3.8 77.73% <ø> (+0.01%) ⬆️
ubuntu-20.04_Python-3.8 78.69% <ø> (+0.02%) ⬆️
windows-2019_Python-3.8 78.59% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cih9088 cih9088 force-pushed the docs/arrow branch 2 times, most recently from ffb5420 to 959b163 Compare April 18, 2023 08:21
docs/source/docs/explanation/formats/arrow.md Outdated Show resolved Hide resolved
docs/source/docs/explanation/formats/arrow.md Outdated Show resolved Hide resolved
docs/source/docs/explanation/formats/arrow.md Outdated Show resolved Hide resolved
docs/source/docs/explanation/formats/arrow.md Outdated Show resolved Hide resolved
docs/source/docs/explanation/formats/arrow.md Outdated Show resolved Hide resolved
cih9088 and others added 6 commits April 18, 2023 18:07
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Co-authored-by: Vinnam Kim <vinnam.kim@gmail.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
Signed-off-by: Inhyuk Andy Cho <andy.inhyuk.jo@intel.com>
@cih9088 cih9088 force-pushed the docs/arrow branch 2 times, most recently from c933869 to 187f2ad Compare April 18, 2023 14:51
Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@cih9088 cih9088 merged commit d950321 into openvinotoolkit:releases/1.2.0 Apr 19, 2023
@cih9088 cih9088 deleted the docs/arrow branch April 19, 2023 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DOC Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants