Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Mapillary Vistas data format #977

Merged
merged 9 commits into from
Apr 27, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented Apr 26, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2023

Codecov Report

Patch coverage: 78.00% and project coverage change: -0.04 ⚠️

Comparison is base (d202060) 78.74% compared to head (483fd94) 78.70%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #977      +/-   ##
===========================================
- Coverage    78.74%   78.70%   -0.04%     
===========================================
  Files          231      231              
  Lines        26463    26454       -9     
  Branches      5263     5261       -2     
===========================================
- Hits         20837    20820      -17     
- Misses        4401     4407       +6     
- Partials      1225     1227       +2     
Flag Coverage Δ
macos-11_Python-3.8 77.74% <78.00%> (-0.03%) ⬇️
ubuntu-20.04_Python-3.8 78.69% <78.00%> (-0.03%) ⬇️
windows-2019_Python-3.8 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../plugins/data_formats/mapillary_vistas/importer.py 75.47% <20.00%> (-4.13%) ⬇️
...maro/plugins/data_formats/mapillary_vistas/base.py 87.34% <84.09%> (-1.04%) ⬇️
...ro/plugins/data_formats/mapillary_vistas/format.py 94.87% <100.00%> (ø)

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee merged commit ce714d2 into openvinotoolkit:develop Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants