Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Synthia data format and Add Synthia AL and SF formats #987

Merged
merged 13 commits into from
May 8, 2023

Conversation

wonjuleee
Copy link
Contributor

@wonjuleee wonjuleee commented May 4, 2023

Summary

How to test

Checklist

  • I have added unit tests to cover my changes.​
  • I have added integration tests to cover my changes.​
  • I have added the description of my changes into CHANGELOG.​
  • I have updated the documentation accordingly

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.
  • I have updated the license header for each file (see an example below).
# Copyright (C) 2023 Intel Corporation
#
# SPDX-License-Identifier: MIT

@codecov-commenter
Copy link

codecov-commenter commented May 4, 2023

Codecov Report

Patch coverage: 96.22% and project coverage change: +0.03 🎉

Comparison is base (fbce79b) 78.71% compared to head (19f1092) 78.75%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #987      +/-   ##
===========================================
+ Coverage    78.71%   78.75%   +0.03%     
===========================================
  Files          231      233       +2     
  Lines        26452    26502      +50     
  Branches      5260     5267       +7     
===========================================
+ Hits         20823    20871      +48     
- Misses        4404     4405       +1     
- Partials      1225     1226       +1     
Flag Coverage Δ
macos-11_Python-3.8 77.78% <96.22%> (+0.03%) ⬆️
ubuntu-20.04_Python-3.8 78.72% <96.22%> (+0.03%) ⬆️
windows-2019_Python-3.8 78.63% <96.22%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
datumaro/util/mask_tools.py 77.59% <66.66%> (-0.86%) ⬇️
datumaro/plugins/data_formats/synthia/base.py 84.95% <95.55%> (ø)
datumaro/plugins/data_formats/synthia/format.py 100.00% <100.00%> (ø)
datumaro/plugins/data_formats/synthia/importer.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@vinnamkim vinnamkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wonjuleee wonjuleee requested a review from cih9088 May 8, 2023 01:34
SynthiaRandLabelMap,
SynthiaRandPath,
SynthiaSfLabelMap,
SynthiaSfPath,
)


def make_categories(label_map=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def make_categories(label_map=None):
def make_categories(label_map):

@wonjuleee wonjuleee merged commit 12ddca4 into openvinotoolkit:develop May 8, 2023
@vinnamkim vinnamkim added this to the 1.3.0 milestone May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants