[PTQ][OV] BF16 support #2307
Open
[PTQ][OV] BF16 support #2307
+318
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
NNCF OpenVINO
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2307 +/- ##
===========================================
+ Coverage 91.18% 91.20% +0.01%
===========================================
Files 483 483
Lines 46412 46435 +23
===========================================
+ Hits 42323 42352 +29
+ Misses 4089 4083 -6
... and 4 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more.
|
l-bat
reviewed
Dec 12, 2023
Comment on lines
249
to
252
| input_low = opset.constant(value=fq_params.input_low.data, dtype=dtype) | ||
| input_high = opset.constant(value=fq_params.input_high.data, dtype=dtype) | ||
| output_low = opset.constant(value=fq_params.output_low.data, dtype=dtype) | ||
| output_high = opset.constant(value=fq_params.output_high.data, dtype=dtype) |
There was a problem hiding this comment.
Are you sure that we don't need clip FQ params before creating the constant node?
There was a problem hiding this comment.
Good catch. I'll look at this.
|
@l-bat, @alexsu52, @andrey-churkin, review, please. |
KodiaqQ
commented
Jun 19, 2024
Comment on lines
203
to
204
| if node_output.get_element_type() != outputs_type: | ||
| node_output = opset.convert(output, destination_type=outputs_type) |
There was a problem hiding this comment.
I would suggest to add flexibility. I mean the insert output transformation command should has dtype parameter to specify return type. By default the return type is FP32.
|
Compression time comparison. Numbers were collected on local i9-10980XE.
No degradations were observed. |
daniil-lyakhov
approved these changes
Jun 19, 2024
| @@ -102,16 +97,16 @@ def _get_activation_node_names(model: ov.Model) -> List[str]: | |||
| return list(activation_nodes) | |||
|
|
|||
| @staticmethod | |||
| def _update_tensor_name(tensors: List[DescriptorTensor], name: str) -> None: | |||
| def _update_tensor_name(tensors: List[DescriptorTensor], names: List[str]) -> None: | |||
There was a problem hiding this comment.
Suggested change
| def _update_tensor_name(tensors: List[DescriptorTensor], names: List[str]) -> None: | |
| def _update_tensor_names(tensors: List[DescriptorTensor], names: List[str]) -> None: |
alexsu52
reviewed
Jun 19, 2024
| @@ -162,7 +161,7 @@ def transform_model( | |||
| should_add_convert_node = True | |||
| break | |||
|
|
|||
| weight = Tensor(get_const_value(const_node, np.float32 if const_dtype == ov.Type.bf16 else None)) | |||
| weight = Tensor(get_const_value(const_node, const_dtype)) | |||
There was a problem hiding this comment.
If I'm not mistaken, then you removed the bf16 to fp32 conversion.
Suggested change
| weight = Tensor(get_const_value(const_node, const_dtype)) | |
| weight = Tensor(get_const_value(const_node)) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
ov.TensorReason for changes
Related tickets
Tests