Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PTQ][OV] BF16 support #2307
[PTQ][OV] BF16 support #2307
Changes from 28 commits
26b6c73
5f02d99
2bcfca9
65ce6dc
4f91018
69e2297
de85c1d
058a6e1
12447d9
627ff67
6f011d9
f3c8ed8
c97c616
ccd0b91
7f670a0
91bb312
ff8f0ca
ca6ff73
11f4929
c67ee84
833f7c9
097e938
106ff8a
d2e5556
5636d1a
d2df92e
4f9cd37
87ea12e
1cdc747
7dfd1c1
9471ac8
8ffe8ae
5405bc9
5f4062b
cfa7ce9
f2add1f
5725636
3e531c4
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This affects outputs for the
then-else
bodies of theif
model. The point is that we should collect all statistics usingfp32
precision. But some outputs may have aboolean
format, not a numeric.What should we do in this case, @kshpv, @alexsu52?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to add flexibility. I mean the insert output transformation command should has
dtype
parameter to specify return type. By default the return type is FP32.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.