Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: [OV JS] Support core.query_model() #24373

Open
almilosz opened this issue May 6, 2024 · 11 comments · May be fixed by #25016
Open

[Good First Issue]: [OV JS] Support core.query_model() #24373

almilosz opened this issue May 6, 2024 · 11 comments · May be fixed by #25016
Assignees
Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers no_stale Do not mark as stale

Comments

@almilosz
Copy link
Contributor

almilosz commented May 6, 2024

Context

Node.js API is the newest binding of OpenVINO.
The task is to expose Core::query_model() method.
Python API documentation of this method

What needs to be done?

  • add query_model() method on C++ side (src/bindings/js/node/src/core_wrap.cpp)
  • update TypeScript definition (src/bindings/js/node/lib/addon.ts)
  • create unit test for added functionality using Node.js Test Runner
    Tip: Before creating a new function to convert an argument, take a look at helper methods to see if it doesn't exist already

Example Pull Requests

Resources

Contact points

@almilosz @vishniakov-nikolai

Ticket

134822

@almilosz almilosz added good first issue Good for newcomers category: JS API OpenVino JS API Bindings no_stale Do not mark as stale labels May 6, 2024
@Aryan8912
Copy link
Contributor

.take

Copy link
Contributor

github-actions bot commented May 7, 2024

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@p-wysocki
Copy link
Contributor

Hello @Aryan8912, there are currently three issues with open PRs assigned to you. Please finish them before picking more tasks.

@hegdeadithyak
Copy link
Contributor

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@hegdeadithyak
Copy link
Contributor

@almilosz To implement this method, I should call _core.query_model(...) , Am I right ?

@almilosz
Copy link
Contributor Author

Yes, C++ docs

@hegdeadithyak
Copy link
Contributor

hegdeadithyak commented May 24, 2024

@almilosz ,Should I work on this or is it closed?

@almilosz almilosz reopened this Jun 4, 2024
@almilosz
Copy link
Contributor Author

almilosz commented Jun 4, 2024

I don't know why it was closed. Sorry

@vishniakov-nikolai
Copy link
Contributor

Hello @hegdeadithyak! Do you need any help with this issue?
Do you have a time to continue work on this task?

@hegdeadithyak
Copy link
Contributor

Yes, ont it will open a PR by tomorrow

@hegdeadithyak hegdeadithyak linked a pull request Jun 13, 2024 that will close this issue
@mlukasze mlukasze linked a pull request Jun 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: JS API OpenVino JS API Bindings good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: In Review
Development

Successfully merging a pull request may close this issue.

5 participants