[OV JS] Expose Model.setFriendlyName and Model.getFriendlyName methods to Node.js api #23743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vishniakov-nikolai @almilosz , I have grouped getFriendlyName and setFriendlyName tests into a single describe block , please let me know your feedback on my PR , Thanks. Best Regards |
Hi @vishniakov-nikolai Thanks for your feedback , I have made the suggested fixes , I will look into my clang formatter config in vs code. |
|
@vishniakov-nikolai there were merge conflicts , while resolving it through UI I missed few syntax in the tests file , which was fixed in the last commit, I added few more formatting fixes in the tests file, ran |
vishniakov-nikolai
approved these changes
Apr 3, 2024
|
build_jenkins |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alvoron
pushed a commit
to alvoron/openvino
that referenced
this pull request
Apr 29, 2024
…s to Node.js api (openvinotoolkit#23743) This fixes openvinotoolkit#23566 Implemented Model.setFriendlyName and Model.getFriendlyName in Node.js api - Added Parameter Validation - Added Tests in model.test.js --------- Co-authored-by: Vishniakov Nikolai <nikolai.vishniakov@intel.com>
This was referenced May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #23566
Implemented Model.setFriendlyName and Model.getFriendlyName in Node.js api