-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
【PaddlePaddle Hackathon 3】Add Paddle box_coder operator #12394
Conversation
@OpenVINO-dev-contest |
Thanks for your contribution. We will review it ASAP. |
@ceciliapeng2011 Could you please review? |
Please fix clang format error. It could automatically fixed with steps -
Then submit PR again. |
@ceciliapeng2011 How can I trigger the code style check? |
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_box_coder.py
Outdated
Show resolved
Hide resolved
src/core/tests/frontend/paddle/test_models/gen_scripts/generate_box_coder.py
Outdated
Show resolved
Hide resolved
I did it for you. |
@ceciliapeng2011 |
paddle 2.1.0 |
@ceciliapeng2011 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to submit the static shape support in this PR. And for dynamic shape situations, if the problem is still there and cannot catch up the deadline, we could solve it in a separate PR. So just comment the code lines and leave it there.
I find that the |
They are just building pass. Paddle FE UT is under "ci/jenkins". Please -
Then I will trigger ci/jenkins again. |
done. I use vscode for code formatting, but it still can not pass. |
@ceciliapeng2011 |
|
Hi @Asthestarsfalll can you help to fix the format issue ? |
Done. |
@ceciliapeng2011 |
@ceciliapeng2011 |
Can you please rebase and resolve the conflicts? Thanks. @Asthestarsfalll |
Head branch was pushed to by a user without write access
Pull request was closed
Done |
@ceciliapeng2011 |
Since this PR has been suspended for nearly two months, I really want to figure out the reason of CI failure.Could you please give me some prompts in this situation? Thanks! |
I am keeping an eye on it. Should be okay after manually triggering the private CI. |
Co-authored-by: Ilya Churaev <ilya.churaev@intel.com>
Details:
add box_coder operation in Paddle front end
Reference:
https://github.com/PaddlePaddle/Paddle/blob/98f8fa4cb3d7b9c14c1897f2716249a54c44f8be/paddle/phi/kernels/cpu/box_coder.cc
The paddle documents are different with source code:
https://www.paddlepaddle.org.cn/documentation/docs/en/1.8/api/layers/box_coder.html
uni-test passed