Update ONNX Python tests #1514
Merged
Update ONNX Python tests #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rblaczkowski
commented
Jul 28, 2020
rblaczkowski
commented
postrational
suggested changes
Jul 29, 2020
rblaczkowski
changed the title
* enable more ONNX python tests * increase XFAIL cases * small refactor
rblaczkowski
force-pushed
the
rblaczkowski/onnx-python-tests-update
branch
from
660b48e
to
91aff8a
Compare
rblaczkowski
requested review from
arogowie-intel,
tsocha,
mitruska,
mbencer,
jiwaszki and
etusien
tsocha
suggested changes
Jul 30, 2020
tsocha
approved these changes
Jul 30, 2020
mitruska
approved these changes
Jul 30, 2020
etusien
approved these changes
Jul 30, 2020
jiwaszki
approved these changes
Jul 30, 2020
arogowie-intel
suggested changes
Jul 31, 2020
| assert_onnx_import_equals_callable("Elu", elu, [-0.9, -0.8, -0.7, -0.4, -0.3, -0.2, -0.1]) | ||
| assert_onnx_import_equals_callable("Elu", elu, [[1, 2, 3], [4, 5, 6]]) | ||
| assert_onnx_import_equals_callable("Elu", elu, [-2, -1.0, 0.0, 1.0, 2.0], alpha=0.5) | ||
| assert_onnx_import_equals_callable("Elu", elu, [-2, -1.0, 0.0, 1.0, 2.0], alpha=alpha_value) |
There was a problem hiding this comment.
I guess you want to use here test parameter:
Suggested change
| assert_onnx_import_equals_callable("Elu", elu, [-2, -1.0, 0.0, 1.0, 2.0], alpha=alpha_value) | |
| assert_onnx_import_equals_callable("Elu", elu, data, alpha=alpha_value) |
There was a problem hiding this comment.
Oh, yes, thanks to point it out
|
|
||
| reduce_data = np.array([[[5, 1], [20, 2]], [[30, 1], [40, 2]], [[55, 1], [60, 2]]], dtype=np.float32) | ||
| reduce_axis_parameters = [ | ||
| # (operation, keepdims - True/False, axis) |
There was a problem hiding this comment.
I'm not sure how this comment relates to the following code...
There was a problem hiding this comment.
Now this comment is deprecated - it was related to previous version - fixed
mbencer
approved these changes
Aug 3, 2020
postrational
suggested changes
Aug 3, 2020
arogowie-intel
approved these changes
Aug 3, 2020
postrational
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.