Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Opset15][Spec] Col2Im-15 specification #23947

Merged
merged 21 commits into from
May 16, 2024
Merged

[Opset15][Spec] Col2Im-15 specification #23947

merged 21 commits into from
May 16, 2024

Conversation

p-wysocki
Copy link
Contributor

@p-wysocki p-wysocki commented Apr 9, 2024 •
edited
Loading

@p-wysocki p-wysocki requested a review from a team as a code owner April 9, 2024 16:40
@p-wysocki p-wysocki requested review from kblaszczak-intel and removed request for a team April 9, 2024 16:41
@github-actions github-actions bot added the category: docs OpenVINO documentation label Apr 9, 2024
@p-wysocki p-wysocki mentioned this pull request Apr 9, 2024
Open
@mlukasze
Copy link
Contributor

please switch to opset 15

@p-wysocki p-wysocki changed the title [Opset14][Spec] Col2Im-14 specification [Opset15][Spec] Col2Im-15 specification Apr 18, 2024
@p-wysocki p-wysocki requested a review from mitruska April 19, 2024 11:20
p-wysocki
p-wysocki commented Apr 19, 2024
View reviewed changes
...es_en/documentation/openvino-ir-format/operation-sets/operation-specs/movement/col2im-15.rst Outdated

.. math::

L = \prod_{d=1}^{2} \left\lfloor \frac{({\text{{output\_size}}[d] + \text{{pads\_begin}}[d] + \text{{pads\_end}}[d] - \text{{dilation}}[d] \times (\text{{kernel\_size}}[d] - 1) - 1}}{{\text{{stride}}[d]}}) + 1\rfloor
Copy link
Contributor Author

@p-wysocki p-wysocki Apr 19, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Where d goes only up to 2 since Col2Im works only for images with 2 spatial dimensions and pads_begin and pads_end are applied separately to follow OpenVINO convention.

@p-wysocki p-wysocki mentioned this pull request Apr 23, 2024
Merged
@t-jankowski t-jankowski requested review from t-jankowski and removed request for t-jankowski May 8, 2024 10:40
@mitruska mitruska added the category: Opset OpenVINO Opset label May 8, 2024
mitruska
mitruska approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@mitruska mitruska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small leftovers, overall LGTM (assuming that 2D case is enough for now).

...es_en/documentation/openvino-ir-format/operation-sets/operation-specs/movement/col2im-15.rst Show resolved Hide resolved
...es_en/documentation/openvino-ir-format/operation-sets/operation-specs/movement/col2im-15.rst Outdated Show resolved Hide resolved
@t-jankowski t-jankowski removed their request for review May 13, 2024 10:48
github-merge-queue bot pushed a commit that referenced this pull request May 14, 2024
@p-wysocki @mlukasze
[Op] Add Col2Im-15 implementation to Core (#24197)
239b578 
### Details:
 - Add Core implementation of `Col2Im-15`

### Related PRs
- #23947

### Tickets:
 - CVS-138918

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
mmikolajcz
mmikolajcz approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@mmikolajcz mmikolajcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...es_en/documentation/openvino-ir-format/operation-sets/operation-specs/movement/col2im-15.rst Outdated Show resolved Hide resolved
@mlukasze mlukasze added this pull request to the merge queue May 16, 2024
Merged via the queue into openvinotoolkit:master with commit 9280cec May 16, 2024
80 checks passed
@p-wysocki p-wysocki mentioned this pull request May 16, 2024
Merged
@p-wysocki p-wysocki deleted the col2im_spec branch May 16, 2024 13:13
@p-wysocki p-wysocki mentioned this pull request May 17, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request May 21, 2024
@p-wysocki @mlukasze
[Op] Col2Im-15 reference implementation (#24548)
fba3ec0 
### Details:
- Similar in functionality to
https://pytorch.org/docs/stable/generated/torch.nn.Fold.html, Col2Im is
`torch.nn.Fold` restricted to two output spatial dimensions

### Tickets:
 - CVS-138919

### Related PRs:
- #24197
- #23947
- #24569

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
github-merge-queue bot pushed a commit that referenced this pull request May 23, 2024
@p-wysocki @mlukasze
[PyOV] Extend Python API with Col2Im-15 (#24569)
c4f33ce 
### Details:
 - Add Python API for `Col2Im-15`
- Requires #24548 to
work and pass CI

### Tickets:
 - CVS-138920

### Related PRs:
- #24548
- #24197
- #23947

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
@p-wysocki p-wysocki mentioned this pull request Jun 10, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Jul 3, 2024
@p-wysocki @mlukasze @maxnick
[Op] Extend CPU Plugin with Col2Im reference implementation (#24931)
ba05386 
### Details:
 - Register `Col2im-15` in CPU Plugin
- Use reference implementation, used
#23844 as reference
 - Add tests

### Tickets:
 - CVS-142438

### Related PRs:
 - #24548
 - #24197
 - #23947
 - #24569

---------

Co-authored-by: Michal Lukaszewski <michal.lukaszewski@intel.com>
Co-authored-by: Maksim Kutakov <maxim.kutakov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t-jankowski t-jankowski t-jankowski left review comments

@mitruska mitruska mitruska approved these changes

@mmikolajcz mmikolajcz mmikolajcz approved these changes

@praasz praasz praasz approved these changes

@kblaszczak-intel kblaszczak-intel Awaiting requested review from kblaszczak-intel kblaszczak-intel is a code owner automatically assigned from openvinotoolkit/openvino-docs-maintainers

Assignees
No one assigned
Labels
category: docs OpenVINO documentation category: Opset OpenVINO Opset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@p-wysocki @mlukasze @mitruska @mmikolajcz @t-jankowski @praasz