Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tensorflow_translators.cpp #122

Closed
wants to merge 6 commits into from

Conversation

MonalSD
Copy link

@MonalSD MonalSD commented Apr 26, 2024

Adding complex input support for translator_equal

Adding complex input support for translator_equal
@rkazants
Copy link
Collaborator

build_jenkins

@MonalSD
Copy link
Author

MonalSD commented Apr 28, 2024

@rkazants please review

@apaniukov apaniukov requested a review from rkazants April 29, 2024 17:28
auto equal_op = std::make_shared<ov::op::v1::Equal>(complex_tensor1, complex_tensor2);
auto reduce_axes = std::make_shared<ov::op::v0::Constant>(ov::element::i32, ov::Shape{1}, std::vector<int32_t>{-1});
auto equal_reduced = std::make_shared<ov::op::v1::ReduceLogicalAnd>(equal_op, reduce_axes, false);
result = equal_reduced;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
result = equal_reduced;
result = equal_reduced;
result.get_node_shared_ptr()->set_friendly_name(node_name);
result.set_names({ node_name + ":0" });
return { result };

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this change the execution flow visit 507 line result = std::make_shared<Equal>(input1, input2)->output(0);

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

again, not fixed. please see execution below

@rkazants
Copy link
Collaborator

rkazants commented May 4, 2024

@MonalSD, please apply comment

@rkazants rkazants closed this Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants