Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why snapshots are built without lzo, lz4 ? #115

Closed
chipitsine opened this issue Oct 29, 2017 · 4 comments
Closed

why snapshots are built without lzo, lz4 ? #115

chipitsine opened this issue Oct 29, 2017 · 4 comments
Labels
deprecated The issue applies to deprecated code only and will be closed when the code will be removed. nsis related to NSIS installer

Comments

@chipitsine
Copy link
Contributor

https://github.com/OpenVPN/openvpn-build/blob/master/windows-nsis/build-snapshot#L35

any special purpose of that ?

@mattock
Copy link
Member

mattock commented Oct 31, 2017

Hmm, not sure. Does it build fine with --disable-lzo and --disable-lz4 removed?

@chipitsine
Copy link
Contributor Author

if we remove --disable-lz4, so lz4 would be built from compat-lz4 (it is a way windows installers are built), but we need to build lzo.

I think, build-complete and build-snapshot are somewhat very similar, I'll try to combine them into single script

@mattock
Copy link
Member

mattock commented Nov 1, 2017

@chipitsine : ok.

@flichtenheld flichtenheld added nsis related to NSIS installer deprecated The issue applies to deprecated code only and will be closed when the code will be removed. labels Jan 20, 2023
@flichtenheld
Copy link
Member

those snapshots don't exist anymore

@flichtenheld flichtenheld closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecated The issue applies to deprecated code only and will be closed when the code will be removed. nsis related to NSIS installer
Projects
None yet
Development

No branches or pull requests

3 participants