Skip to content

Commit

Permalink
Remove ageing check in run_put_mac_binding
Browse files Browse the repository at this point in the history
Remove ageing check in run_put_mac_binding routine on mac-binding info
since if ovn-controller main thread is heavy loaded the info will be
discarded and the mac_binding table will not never be updated

Acked-by: Numan Siddique <nusiddiq@redhat.com>
Signed-off-by: Lorenzo Bianconi <lorenzo.bianconi@redhat.com>
  • Loading branch information
LorenzoBianconi authored and Alin Gabriel Serdean committed Jul 15, 2020
1 parent a5c8454 commit 0ee6bd9
Showing 1 changed file with 0 additions and 7 deletions.
7 changes: 0 additions & 7 deletions ovn/controller/pinctrl.c
Original file line number Diff line number Diff line change
Expand Up @@ -2549,8 +2549,6 @@ pinctrl_destroy(void)
struct put_mac_binding {
struct hmap_node hmap_node; /* In 'put_mac_bindings'. */

long long int timestamp; /* In milliseconds. */

/* Key. */
uint32_t dp_key;
uint32_t port_key;
Expand Down Expand Up @@ -2624,7 +2622,6 @@ pinctrl_handle_put_mac_binding(const struct flow *md,
pmb->port_key = port_key;
pmb->ip_key = ip_key;
}
pmb->timestamp = time_msec();
pmb->mac = headers->dl_src;

/* We can send the buffered packet once the main ovn-controller
Expand Down Expand Up @@ -2672,10 +2669,6 @@ run_put_mac_binding(struct ovsdb_idl_txn *ovnsb_idl_txn,
struct ovsdb_idl_index *sbrec_mac_binding_by_lport_ip,
const struct put_mac_binding *pmb)
{
if (time_msec() > pmb->timestamp + 1000) {
return;
}

/* Convert logical datapath and logical port key into lport. */
const struct sbrec_port_binding *pb = lport_lookup_by_key(
sbrec_datapath_binding_by_key, sbrec_port_binding_by_key,
Expand Down

0 comments on commit 0ee6bd9

Please sign in to comment.