Skip to content

Commit

Permalink
datapath: Fix an error handling path in 'ovs_nla_init_match_and_action()
Browse files Browse the repository at this point in the history
Upstream commit:
commit 5829e62ac17a40ab08c1b905565604a4b5fa7af6
Author: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Date:   Mon Sep 11 21:56:20 2017 +0200

    openvswitch: Fix an error handling path in 'ovs_nla_init_match_and_action()'

    All other error handling paths in this function go through the 'error'
    label. This one should do the same.

    Fixes: 9cc9a5cb176c ("datapath: Avoid using stack larger than 1024.")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Acked-by: Pravin B Shelar <pshelar@ovn.org>
    Signed-off-by: David S. Miller <davem@davemloft.net>

Cc: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Fixes: 850c2a4 ("datapath: Avoid using stack larger than 1024.")
Signed-off-by: Greg Rose <gvrose8192@gmail.com>
Acked-by: Pravin B Shelar <pshelar@ovn.org>
  • Loading branch information
tititiou36 authored and pshelar committed Feb 12, 2018
1 parent a61fbfa commit 497895c
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion datapath/datapath.c
Original file line number Diff line number Diff line change
Expand Up @@ -1140,7 +1140,8 @@ static int ovs_nla_init_match_and_action(struct net *net,
if (!a[OVS_FLOW_ATTR_KEY]) {
OVS_NLERR(log,
"Flow key attribute not present in set flow.");
return -EINVAL;
error = -EINVAL;
goto error;
}

*acts = get_flow_actions(net, a[OVS_FLOW_ATTR_ACTIONS], key,
Expand Down

0 comments on commit 497895c

Please sign in to comment.