Skip to content

Commit

Permalink
ovn-controller: Drop unknown datapath log message.
Browse files Browse the repository at this point in the history
This patch emits a log message that is encountered a lot under normal
circumstances.  For example, I'm seeing it almost 20,000 times in a
test run of the OpenStack test suite and hundreds of times while doing
basic tasting under ovs-sandbox.

ovn-controller keeps a hash of logical data paths that have ports
associated with them (logical_datapaths).  This message occurs when
looping through all Pipeline entries and a Pipeline's logical datapath
does not exist in this hash.  However, a logical switch with no ports
will have entries in the Pipeline table, but nothing in Bindings (and
not end up in the logical_datapaths hash).  Currently, this message
will be emitted 6 times for every logical switch without any logical
ports every time the ovn-controller main loop comes around and runs
this code.  Instead, the right thing to do to silently ignore the
pipeline entry, because there's nothing useful to be done with it.

Signed-off-by: Russell Bryant <rbryant@redhat.com>
Signed-off-by: Ben Pfaff <blp@nicira.com>
  • Loading branch information
russellb authored and blp committed May 29, 2015
1 parent 54c77a3 commit 7679441
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ovn/controller/pipeline.c
Original file line number Diff line number Diff line change
Expand Up @@ -270,10 +270,6 @@ pipeline_run(struct controller_ctx *ctx)
const struct logical_datapath *ldp;
ldp = ldp_lookup(&pipeline->logical_datapath);
if (!ldp) {
static struct vlog_rate_limit rl = VLOG_RATE_LIMIT_INIT(1, 1);
VLOG_INFO_RL(&rl,
"logical flow for unknown logical datapath "UUID_FMT,
UUID_ARGS(&pipeline->logical_datapath));
continue;
}

Expand Down

0 comments on commit 7679441

Please sign in to comment.