Skip to content

Commit

Permalink
ovs-vsctl.at: Use OVS_VSCTL_CLEANUP.
Browse files Browse the repository at this point in the history
OVSDB_SERVER_SHUTDOWN defined in another module and not inside
'*-macros.at'. So, it should not be used inside ovs-vsctl.at.

Also, OVS_VSCTL_CLEANUP should be used instead of direct calls
to OVSDB_SERVER_SHUTDOWN.

Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Acked-by: Daniele Di Proietto <diproiettod@vmware.com>
  • Loading branch information
igsilya authored and ddiproietto committed Jun 7, 2016
1 parent c673049 commit 868dae9
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/ovs-vsctl.at
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ m4_define([OVS_VSCTL_SETUP],
dnl OVS_VSCTL_CLEANUP
dnl
dnl Kills off the database server.
m4_define([OVS_VSCTL_CLEANUP], [OVSDB_SERVER_SHUTDOWN])
m4_define([OVS_VSCTL_CLEANUP], [OVS_APP_EXIT_AND_WAIT(["`pwd`"/unixctl])])

dnl RUN_OVS_VSCTL(COMMAND, ...)
dnl
Expand Down Expand Up @@ -1332,7 +1332,7 @@ AT_CHECK([ovs-vsctl -t 5 --no-wait --db=ssl:127.0.0.1:$SSL_PORT --private-key=$P
AT_CHECK([ovs-vsctl -t 5 --no-wait --db=ssl:127.0.0.1:$SSL_PORT --private-key=$PKIDIR/vsctl-privkey.pem --certificate=$PKIDIR/vsctl-cert.pem --bootstrap-ca-cert=$PKIDIR/cacert.pem list-br], [0], [br0
])

OVSDB_SERVER_SHUTDOWN
OVS_VSCTL_CLEANUP
AT_CLEANUP

AT_SETUP([peer ca cert])
Expand All @@ -1359,5 +1359,5 @@ AT_CHECK([ovs-vsctl -t 5 --no-wait --db=ssl:127.0.0.1:$SSL_PORT --private-key=$P
AT_CHECK([ovs-vsctl -t 5 --no-wait --db=ssl:127.0.0.1:$SSL_PORT --private-key=$PKIDIR/vsctl-privkey.pem --certificate=$PKIDIR/vsctl-cert.pem --bootstrap-ca-cert=$PKIDIR/cacert.pem list-br], [0], [br0
])

OVSDB_SERVER_SHUTDOWN
OVS_VSCTL_CLEANUP
AT_CLEANUP

0 comments on commit 868dae9

Please sign in to comment.