Fixes: #462: Fix race condition in method sendResponse in com.android.identity.wallet.transfer.Communication #463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicklaswj
commented
Jan 31, 2024
appholder/src/main/java/com/android/identity/wallet/transfer/TransferManager.kt
Outdated
Show resolved
Hide resolved
nicklaswj
force-pushed
the
fix-sendResponse-race-condition
branch
from
488360d
to
60f9643
Compare
added 2 commits
February 1, 2024 09:20
….transfer.Communication sendResponse If `closeAfterSending` is true, only close the connection after we know the `deviceResponse` payload have been sent. Signed-off-by: Nicklas Warming Jacobsen <nicklas.jacobsen@ocrlabs.com>
Signed-off-by: Nicklas Warming Jacobsen <nicklas.jacobsen@ocrlabs.com>
nicklaswj
force-pushed
the
fix-sendResponse-race-condition
branch
from
b2c04b2
to
069e9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #462
This PR changes the method
sendResponsein classCommunicationto only close the underlyingmTransportafter thedeviceResponsehas been fully sent.