-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add matrix for testing #111
Conversation
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
@lukasjhan you are correct, it seems that version 18 is and lower is not supported. At this point we have to decide:
I haven't looked if we can implement the whole crypto-node stuff without the subtle. Code reusage is not possible then, but on the other hand the amount of functions is small that need to be implemented |
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #111 +/- ##
==========================================
- Coverage 94.96% 94.96% -0.01%
==========================================
Files 21 21
Lines 1530 1529 -1
Branches 235 235
==========================================
- Hits 1453 1452 -1
Misses 72 72
Partials 5 5 ☔ View full report in Codecov by Sentry. |
So the good news is that the node code is working fine in nodejs v16 18 and 20 :) But I needed to outcomment the browser test since these tests seem not to be performed as a browser test, but a node test and therefore the tests failed since node subtle is not supported with all requirements. We should try to find a solution for the browser tests to get them up and running again before merging this |
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Found a good solution: So we can also make sure the whole code base is running on node 16. I didn't check lower since from my point of view supporting 3 LTS versions should be enough. |
3 LTS looks good :) |
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
Signed-off-by: Mirko Mollik <mirko.mollik@fit.fraunhofer.de>
adding the matrix testing approach allows us to test it for different versions