feat(indy-sdk)!: move to did:indy with limited support #1347

TimoGlastra · 2023-02-25T15:30:36Z

Adds full did:indy support for the indy-sdk package, while still keeping support for did:sov dids in interactions with other agents.

The IndySdkAnonCredsRegistry now supports resolving both did:indy and legacy unqualified anoncreds objects. I wasn't sure on making it two separate classes due to the duplication. I think it's okay that they're combined for now, but it may be nice to split them up at some point so users could choose to e.g. not support the legacy identifiers anymore.

In addition a new IndySdkIndyDidRegistrar has been added. This doesn't support the diddocContent. The IndySdkSovDidRegistrar has been removed. From now on you can create did:indy dids, which contain the namespace, but you can keep on using the did:sov resolvers.

For registering anoncreds object you can now only use did:indy identifiers as this will contain the namespace, but you can still use the unqualified ones in using the legacy indy credential format services.

~~There's some additional work needed to the indy sdk issuer/holder/verifier services to make sure we can handle but qualified and unqualified dids and can also use them interchangeably.~~

Note
I don't think we're able to support did:indy using the indy-sdk as the identifiers are part of the credential meaning the identifiers in the credentials always must be unqualfiied as indy-sdk doesn't allow qualified input. I still think primarily supporting did:indy when creating objects is a good choice, as it allows us to prevent a lot of the ambiguity around which ledger to use.

I'll make a similar PR for the indy-vdr package so they'll be in feature parity.

BREAKING CHANGE: The IndySdkSovDidRegistrar has been removed in favour of the new IndySdkIndyDidRegistar. you can register the same dids as you could do with the IndySdkSovDidRegistrar, but now with less ambiguity on which ledger should be used as that's encoded in the did itself.

Signed-off-by: Timo Glastra <timo@animo.id>

packages/indy-sdk/src/anoncreds/utils/identifiers.ts

+export function parseRevocationRegistryId(revocationRegistryId: string) {
+  const match =
+    revocationRegistryId.match(didIndyRevocationRegistryIdRegex) ??
+    revocationRegistryId.match(legacyIndyRevocationRegistryIdRegex)


codecov-commenter · 2023-02-25T15:39:33Z

Codecov Report

Merging #1347 (b90e41a) into main (7795975) will decrease coverage by 15.06%.
The diff coverage is 81.13%.

@@             Coverage Diff             @@
##             main    #1347       +/-   ##
===========================================
- Coverage   86.65%   71.60%   -15.06%     
===========================================
  Files         778      694       -84     
  Lines       18476    16692     -1784     
  Branches     3163     2861      -302     
===========================================
- Hits        16011    11952     -4059     
- Misses       2458     4737     +2279     
+ Partials        7        3        -4

Impacted Files	Coverage Δ
packages/indy-sdk/src/dids/didSovUtil.ts	`90.90% <ø> (-6.07%)`	⬇️
...sdk/src/anoncreds/services/IndySdkIssuerService.ts	`22.91% <28.57%> (+1.98%)`	⬆️
...sdk/src/anoncreds/services/IndySdkHolderService.ts	`8.54% <33.33%> (ø)`
...k/src/anoncreds/services/IndySdkVerifierService.ts	`21.87% <33.33%> (ø)`
packages/indy-sdk/src/anoncreds/utils/transform.ts	`48.38% <33.33%> (-0.19%)`	⬇️
...ackages/indy-sdk/src/dids/IndySdkSovDidResolver.ts	`68.42% <50.00%> (-17.30%)`	⬇️
...kages/indy-sdk/src/dids/IndySdkIndyDidRegistrar.ts	`72.72% <72.72%> (ø)`
...ckages/indy-sdk/src/dids/IndySdkIndyDidResolver.ts	`80.00% <80.00%> (ø)`
packages/indy-sdk/src/ledger/IndySdkPoolService.ts	`95.03% <92.30%> (-0.42%)`	⬇️
...ckages/indy-sdk/src/anoncreds/utils/identifiers.ts	`95.00% <94.59%> (-5.00%)`	⬇️
... and 308 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Timo Glastra <timo@animo.id>

genaris

Pretty interesting work here. Really like the usage of regex with named groups. Certainly very useful for DID and AnonCreds object parsing!

Even if I'm not so convinced about the needs of indy-sdk-based did:indy registrar and resolver considering its limited capabilities, I do see value on it for leveraging everyone to move to this new concept and move away from legacy did:sov.

My remarks are mainly some warnings regarding the importance of documenting well about these limitations and maybe recommending everyone to switch to indy-vdr as soon as possible to fully support did:indy. BTW, this PR's name suggested me that it would bring a true full support for did:indy (with diddocContent and everything), and now I feel like I fell into a marketing trap 😆.

packages/anoncreds/tests/InMemoryAnonCredsRegistry.ts

genaris · 2023-02-27T00:04:28Z

packages/indy-sdk/src/dids/IndySdkIndyDidRegistrar.ts

+      const { namespace: submitterNamespace, id: submitterDidIdentifier } = parseIndyDid(submitterDid)
+      const submitterSigningKey = await verificationKeyForIndyDid(agentContext, submitterDid)
+
+      // Only supports version 1 did identifier (which is same as did:sov)


So indy-sdk has a 'ver' field hard-coded to 1?

For the moment, I think it's OK to leave this comment only internal, but once indy-vdr and indy-node officially supports it I think we'll need to add transactionVersion to DidCreateOptions for both implementations, making explicit that only '1' is allowed for indy-sdk while 0, 1 and 2 will be possible for indy-vdr.

Not sure what you mean. I mean the 1 from here: https://hyperledger.github.io/indy-did-method/#nym-transaction-version

Yes, I'm referring to that too! When I've read that before implementing IndyVdr did:indy classes, I understood that it would be possible for an app to indicate whether to use 0, 1 or 2 when creating a DID, so I imagined having an extra parameter in the DidRegistrar that would allow us to specify the transactionVersion.

So, in case of IndyVdr, we could set transactionVersion=1 if we wish to register a did:sov and transactionVersion=2 if we want to register a brand-new did:indy. Even a transactionVersion=0 would be possible (for super legacy ledgers I think... not sure why it was added).

Do you think this transaction version will be always hard-coded on the indy library? (i.e. 1 for indy-sdk and probably 2 for indy-vdr with did:indy support?)

I understand. Yeah we should probably make that configurable and default to transactionVersion=1. However we can't set the transaction version I think with the indy-sdk?

Yeah, for indy-sdk will be always 1. We just need to make clear about this limitation either in docs or by adding this transactionVersion to DidCreateOptions whose only possible value is '1'. This is of course not for this PR.

genaris · 2023-02-27T00:15:03Z

packages/indy-sdk/src/dids/IndySdkIndyDidResolver.ts

+      const verkey = getFullVerkey(did, nym.verkey)
+      const builder = indyDidDocumentFromDid(did, verkey)
+
+      // NOTE: we don't support the `diddocContent` field in the GET_NYM response using the indy-sdk. So if the did would have the `diddocContent` field


This is a very important note. Surely it will need to be published in the module README. I'm not sure if it will be possible to get the diddocContent field from the GET_NYM response using the indy-sdk as it is right now. If that will be the case, it could be a bit misleading to have an IndyDidResolver class that is not able to parse a did:indy that conforms to the specification.

Yeah good point. I think it should just return it in the JSON. The NYM transaction is stored as stringified JSON on the ledger. We may not be able to use the parse method from the indy-sdk, but we should be able to extract the diddocContent property. If we get to this point, we can look into it again. But I think before we have did:indy dids takes written to the ledger will take a while, and I'm not particularly keen to wait for it...

I agree! I had the same doubts when implementing it for indy-vdr and did some assumptions as a result. The time will tell 😆

…t-foundation#1314) Signed-off-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: Agent default outbound content type has been changed to DIDComm V1. If you want to use former behaviour, you can do it so by manually setting `didcommMimeType` in `Agent`'s init config: ``` const agent = new Agent({ config: { ... didCommMimeType: DidCommMimeType.V0 }, ... }) ```

…ion#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com>

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra · 2023-02-28T14:01:23Z

Not sure how to fix the revocation registry regex issue. It's just the regex that ACA-Py also uses. Should we impose a character limit on the id length?

…did-support

Signed-off-by: Timo Glastra <timo@animo.id>

commit 0351eec Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 15 12:02:50 2023 -0300 fix: connection id in sessions for new connections (openwallet-foundation#1383) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit f27fb99 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 15 09:23:10 2023 -0300 feat: basic message pthid/thid support (openwallet-foundation#1381) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit d59366a Author: Jim Ezesinachi <ezesinachijim@gmail.com> Date: Wed Mar 15 11:04:52 2023 +0100 docs: fix example usage of indy-sdk-react-native package (openwallet-foundation#1382) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit a4204ef Author: Timo Glastra <timo@animo.id> Date: Sat Mar 11 16:31:09 2023 +0100 fix: remove named capture groups (openwallet-foundation#1378) named capture groups are only supported in more recent versions of hermes Signed-off-by: Timo Glastra <timo@animo.id> commit dd6c020 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Mar 11 11:57:37 2023 -0300 feat(anoncreds-rs): use new API methods for json conversion (openwallet-foundation#1373) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 122cdde Author: Timo Glastra <timo@animo.id> Date: Sat Mar 11 13:31:09 2023 +0100 fix: return HTTP 415 if unsupported content type (openwallet-foundation#1313) Signed-off-by: Timo Glastra <timo@animo.id> commit 582c711 Author: Mo <10432473+morrieinmaas@users.noreply.github.com> Date: Sat Mar 11 12:08:02 2023 +0100 feat: outbound message send via session (openwallet-foundation#1335) Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Moriarty <moritz@animo.id> commit 19cefa5 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Mar 11 07:20:49 2023 -0300 feat(askar): import/export wallet support for SQLite (openwallet-foundation#1377) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c72ba14 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 17:40:03 2023 +0100 fix(askar): custom error handling (openwallet-foundation#1372) Signed-off-by: Timo Glastra <timo@animo.id> commit 39c4ed0 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 16:52:12 2023 +0100 feat(indy-vdr)!: extend did:indy support (openwallet-foundation#1362) Signed-off-by: Timo Glastra <timo@animo.id> commit 01669a7 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 14:48:34 2023 +0100 test: increase timeout to 120 seconds (openwallet-foundation#1375) Signed-off-by: Timo Glastra <timo@animo.id> commit 953069a Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Mar 6 10:28:30 2023 -0300 fix(core): repository event when calling deleteById (openwallet-foundation#1356) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c133538 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Mar 6 08:26:42 2023 -0300 fix(anoncreds): Buffer not imported from core (openwallet-foundation#1367) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 8f6b344 Author: Timo Glastra <timo@animo.id> Date: Fri Mar 3 12:15:58 2023 +0100 feat(indy-sdk)!: move to did:indy with limited support (openwallet-foundation#1347) Signed-off-by: Timo Glastra <timo@animo.id> commit 7795975 Author: Martin Auer <martin.auer97@gmail.com> Date: Fri Mar 3 11:07:43 2023 +0100 fix(tenant): Correctly configure storage for multi tenant agents (openwallet-foundation#1359) Fixes hyperledger#1353 Signed-off-by: martin auer <martin.auer97@gmail.com> commit cb4e469 Author: Timo Glastra <timo@animo.id> Date: Thu Mar 2 22:38:14 2023 +0100 test: various improvements (openwallet-foundation#1361) Signed-off-by: Timo Glastra <timo@animo.id> commit fd13bb8 Author: Ariel Gentile <gentilester@gmail.com> Date: Thu Mar 2 17:00:57 2023 -0300 feat(oob): implicit invitations (openwallet-foundation#1348) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 18abb18 Author: Pritam Singh <43764373+Zzocker@users.noreply.github.com> Date: Thu Mar 2 22:11:20 2023 +0530 fix: isNewSocket logic (openwallet-foundation#1355) Signed-off-by: Pritam Singh <pkspritam16@gmail.com> commit 2c792fe Author: Martin Auer <martin.auer97@gmail.com> Date: Thu Mar 2 14:29:05 2023 +0100 refactor!: remove getKeyDidMappingByVerificationMethod (openwallet-foundation#1350) Signed-off-by: martin auer <martin.auer97@gmail.com> commit 78ecf1e Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 1 18:44:26 2023 -0300 refactor!: remove Dispatcher.registerMessageHandler (openwallet-foundation#1354) BREAKING CHANGE: `Dispatcher.registerMessageHandler` has been removed in favour of `MessageHandlerRegistry.registerMessageHandler`. If you want to register message handlers in an extension module, you can use directly `agentContext.dependencyManager.registerMessageHandlers`. Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 1bda3f0 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 27 15:35:16 2023 -0300 fix(anoncreds-rs): save revocation registry index (openwallet-foundation#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 4ab3b54 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 27 13:23:47 2023 +0100 refactor!: set default outbound content type to didcomm v1 (openwallet-foundation#1314) Signed-off-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: Agent default outbound content type has been changed to DIDComm V1. If you want to use former behaviour, you can do it so by manually setting `didcommMimeType` in `Agent`'s init config: ``` const agent = new Agent({ config: { ... didCommMimeType: DidCommMimeType.V0 }, ... }) ``` commit 254f661 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Feb 25 11:49:36 2023 -0300 fix(indy-sdk): import from core (openwallet-foundation#1346) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 21d4bf7 Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 22:20:54 2023 +0100 feat!: allow to import created dids (and remove legacy `publicDidSeed`) (openwallet-foundation#1325) Signed-off-by: Timo Glastra <timo@animo.id> commit dc60acb Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 20:50:28 2023 +0100 build(anoncreds): remove node package from deps (openwallet-foundation#1339) Signed-off-by: Timo Glastra <timo@animo.id> commit e14d853 Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 17:59:30 2023 +0100 test: increase indy-sdk timeout (openwallet-foundation#1345) Signed-off-by: Timo Glastra <timo@animo.id> commit d38ecb1 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 24 09:12:40 2023 -0300 fix(anoncreds): include prover_did for legacy indy (openwallet-foundation#1342) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit da8f2ad Author: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Date: Fri Feb 24 13:01:47 2023 +0200 fix: create new socket if socket state is 'closing' (openwallet-foundation#1337) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> commit cac2ec3 Author: Martin Auer <martin.auer97@gmail.com> Date: Fri Feb 24 11:11:28 2023 +0100 refactor(core)!: remove deprecated injectionContainer prop (openwallet-foundation#1344) Signed-off-by: martin auer <martin.auer97@gmail.com> commit d5e34ff Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 24 06:19:32 2023 -0300 test(indy-sdk): wait before resolving ledger objects (openwallet-foundation#1340) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 518e5e4 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Feb 22 04:36:33 2023 -0300 fix: expose indy pool configs and action menu messages (openwallet-foundation#1333) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 1c6aeae Author: Ariel Gentile <gentilester@gmail.com> Date: Tue Feb 21 19:18:19 2023 -0300 fix(askar): anoncrypt messages unpacking (openwallet-foundation#1332) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit fb7ee50 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Tue Feb 21 15:39:14 2023 +0100 feat: IndyVdrAnonCredsRegistry revocation methods (openwallet-foundation#1328) Signed-off-by: Victor Anene <victor@animo.id> commit 64e20f1 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 17:07:30 2023 +0100 fix!: don't emit legacy did:sov prefix for new protocols (openwallet-foundation#1245) Signed-off-by: Timo Glastra <timo@animo.id> commit c0e5339 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 20 09:04:20 2023 -0300 fix: seed and private key validation and return type in registrars (openwallet-foundation#1324) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit edf392f Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 12:14:21 2023 +0100 refactor: remove master secret id from wallet (openwallet-foundation#1320) Signed-off-by: Timo Glastra <timo@animo.id> commit b6d66b1 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 00:59:42 2023 +0100 refactor!: remove indy from core (openwallet-foundation#1286) Signed-off-by: Timo Glastra <timo@animo.id> commit 616b908 Author: Ariel Gentile <gentilester@gmail.com> Date: Sun Feb 19 13:27:16 2023 -0300 feat(wallet)!: createKey from private key (openwallet-foundation#1301) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 64a5da9 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Feb 18 16:54:25 2023 -0300 fix(samples): dummy module response message type (openwallet-foundation#1321) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit ff5596d Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 17 23:10:09 2023 -0300 feat!: add data, cache and temp dirs to FileSystem (openwallet-foundation#1306) Signed-off-by: Ariel Gentile <gentilester@gmail.com> BREAKING CHANGE: Agent-produced files will now be divided in different system paths depending on their nature: data, temp and cache. Previously, they were located at a single location, defaulting to a temporary directory. If you specified a custom path in `FileSystem` object constructor, you now must provide an object containing `baseDataPath`, `baseTempPath` and `baseCachePath`. They can point to the same path, although it's recommended to specify different path to avoid future file clashes. commit af384e8 Author: Timo Glastra <timo@animo.id> Date: Sat Feb 18 01:32:45 2023 +0100 fix: loosen base64 validation (openwallet-foundation#1312) Signed-off-by: Timo Glastra <timo@animo.id> commit 229ed1b Author: Timo Glastra <timo@animo.id> Date: Fri Feb 17 21:31:47 2023 +0100 fix: thread id improvements (openwallet-foundation#1311) Signed-off-by: Timo Glastra <timo@animo.id> commit 1d782f5 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Fri Feb 17 20:01:35 2023 +0100 feat: add fetch indy schema method (openwallet-foundation#1290) Signed-off-by: Victor Anene <victor@animo.id> commit 3e02227 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Feb 15 20:14:47 2023 -0300 fix: imports from core (openwallet-foundation#1303) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 4ac5332 Author: Jason C. Leach <jason.leach@fullboar.ca> Date: Wed Feb 15 14:11:41 2023 -0800 feat: add devcontainer support (openwallet-foundation#1282) Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca> commit efab8dd Author: Ariel Gentile <gentilester@gmail.com> Date: Tue Feb 14 19:49:59 2023 -0300 feat(indy-vdr): resolver and registrar for did:indy (openwallet-foundation#1253) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit a487705 Author: Timo Glastra <timo@animo.id> Date: Tue Feb 14 10:57:22 2023 +0100 docs: update readme (openwallet-foundation#1298) docs: update reaadme Signed-off-by: Timo Glastra <timo@animo.id> commit ecce0a7 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 13 19:01:39 2023 -0300 fix(askar): generate nonce suitable for anoncreds (openwallet-foundation#1295) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c63350c Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 20:58:46 2023 +0100 test: add anoncreds restriction test (openwallet-foundation#1294) Signed-off-by: Timo Glastra <timo@animo.id> commit b570e0f Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 19:49:21 2023 +0100 fix(indy-vdr): export relevant packages from root (openwallet-foundation#1291) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit c72fd74 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 18:40:44 2023 +0100 feat(anoncreds): legacy indy proof format service (openwallet-foundation#1283) Signed-off-by: Timo Glastra <timo@animo.id> commit dfb3eaf Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 16:23:41 2023 +0100 build(indy-sdk): set private to false (openwallet-foundation#1293) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit 231145f Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 13 10:22:44 2023 -0300 chore: make askar, anoncreds(-rs), indy-vdr packages public (openwallet-foundation#1292) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit fb8d58b Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 12:57:35 2023 +0100 refactor(proofs)!: generalize proofs api and improve consistency with credentials module (openwallet-foundation#1279) Signed-off-by: Timo Glastra <timo@animo.id> commit 51030d4 Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 11:43:02 2023 +0100 feat(indy-vdr): module registration (openwallet-foundation#1285) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit d61f6ed Author: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Date: Mon Feb 13 09:23:17 2023 +0100 chore(core): remove useless file (openwallet-foundation#1288) commit 30857b9 Author: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Date: Sat Feb 11 22:50:10 2023 +0100 fix(transport)!: added docs moved connection to connectionId (openwallet-foundation#1222) Signed-off-by: blu3beri <blu3beri@proton.me> commit efe0271 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 10 19:15:36 2023 -0300 feat: add anoncreds-rs package (openwallet-foundation#1275) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 2669d7d Author: KolbyRKunz <KolbyKunz@yahoo.com> Date: Fri Feb 10 14:14:59 2023 -0700 fix: set updateAt on records when updating a record (openwallet-foundation#1272) Signed-off-by: KolbyRKunz <kolbykunz@yahoo.com> commit 1d487b1 Author: Jim Ezesinachi <jim@animo.id> Date: Fri Feb 10 20:21:20 2023 +0100 feat: added endpoint setter to agent InitConfig (openwallet-foundation#1278) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit 86cb9d0 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 10 11:13:44 2023 -0300 ci: increase maximum heap memory for node (openwallet-foundation#1280) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit d056316 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Fri Feb 10 01:31:43 2023 +0100 feat(indy-vdr): add IndyVdrAnonCredsRegistry (openwallet-foundation#1270) Signed-off-by: Timo Glastra <timo@animo.id> commit f18d189 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 6 23:34:21 2023 -0300 feat: add initial askar package (openwallet-foundation#1211) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 115d897 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 6 23:45:01 2023 +0000 build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (openwallet-foundation#1258) commit 3d86e78 Author: Karim Stekelenburg <karim@animo.id> Date: Tue Feb 7 00:09:24 2023 +0100 feat(openid4vc-client): pre-authorized (openwallet-foundation#1243) This PR adds support for the `pre-authorized` OpenID for Verifiable Credentials issuance flow to the new `openid4vc-client` module. Here are some highlights of the work: - Allows the user to execute the entire `pre-authorized` flow by calling a single method. - Adds a happy-flow test - HTTP(S) requests and responses are mocked using a network mocking library called [nock](https://github.com/nock/nock) - Because the JSON-LD credential that is received is expanded by the `W3cCredentialService`, I've added a few new contexts to our test document loader. - Not-so-happy-flow tests will be added later on. If you have any suggestions for edge cases that deserve testing, feel free to drop a comment. - Modifies the `JwsService` - The `JwsService` was geared towards a very specific use case. I've generalized its API so it's usable for a wider range of applications. - All pre-existing tests and calls to the `JwsService` have been updated. It's worth noting that I have had to add some `@ts-ignore` statements here and there to get around some incomplete types in the `OpenID4VCI-Client` library we're using. Once these issues have been resolved in the client library, they will be removed. **Work funded by the government of Ontario** --------- Signed-off-by: Karim Stekelenburg <karim@animo.id> Co-authored-by: Timo Glastra <timo@animo.id> commit 7f65ba9 Author: Jim Ezesinachi <jim@animo.id> Date: Mon Feb 6 22:27:03 2023 +0100 feat: optional routing for legacy connectionless invitation (openwallet-foundation#1271) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit 3a4c5ec Author: Timo Glastra <timo@animo.id> Date: Mon Feb 6 21:49:12 2023 +0100 feat(anoncreds): add anoncreds API (openwallet-foundation#1232) Signed-off-by: Timo Glastra <timo@animo.id>

…undation#1347) Signed-off-by: Timo Glastra <timo@animo.id>

feat(indy-sdk)!: full did:indy support

0e81028

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra requested a review from a team as a code owner February 25, 2023 15:30

github-advanced-security bot found potential problems Feb 25, 2023

View reviewed changes

fix: broken tests

333b185

Signed-off-by: Timo Glastra <timo@animo.id>

genaris approved these changes Feb 27, 2023

View reviewed changes

TimoGlastra changed the title ~~feat(indy-sdk)!: full did:indy support~~ feat(indy-sdk)!: move to did:indy with limited support Feb 27, 2023

TimoGlastra and others added 3 commits February 28, 2023 14:59

fix(anoncreds-rs): save revocation registry index (openwallet-foundat…

0dba4b9

…ion#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com>

chore: address feedback

128a817

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra added 2 commits February 28, 2023 15:01

Merge branch 'main' into feat/indy-sdk-indy-did-support

ff5e5e7

Merge branch 'main' into feat/indy-sdk-indy-did-support

259a615

TimoGlastra mentioned this pull request Mar 2, 2023

feat(indy-vdr)!: extend did:indy support #1362

Merged

Merge remote-tracking branch 'upstream/main' into feat/indy-sdk-indy-…

46632eb

…did-support

TimoGlastra enabled auto-merge (squash) March 3, 2023 10:10

updates

b90e41a

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra merged commit 8f6b344 into openwallet-foundation:main Mar 3, 2023

karimStekelenburg pushed a commit to karimStekelenburg/aries-framework-javascript that referenced this pull request Mar 17, 2023

feat(indy-sdk)!: move to did:indy with limited support (openwallet-fo…

f5fe05b

…undation#1347) Signed-off-by: Timo Glastra <timo@animo.id>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(indy-sdk)!: move to did:indy with limited support #1347

feat(indy-sdk)!: move to did:indy with limited support #1347

TimoGlastra commented Feb 25, 2023 •

edited

codecov-commenter commented Feb 25, 2023 •

edited

genaris left a comment

genaris Feb 27, 2023

TimoGlastra Feb 27, 2023

genaris Feb 27, 2023

TimoGlastra Feb 27, 2023

genaris Feb 27, 2023

genaris Feb 27, 2023

TimoGlastra Feb 27, 2023

genaris Feb 27, 2023

TimoGlastra commented Feb 28, 2023

feat(indy-sdk)!: move to did:indy with limited support #1347

feat(indy-sdk)!: move to did:indy with limited support #1347

Conversation

TimoGlastra commented Feb 25, 2023 • edited

codecov-commenter commented Feb 25, 2023 • edited

Codecov Report

genaris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

TimoGlastra commented Feb 28, 2023

TimoGlastra commented Feb 25, 2023 •

edited

codecov-commenter commented Feb 25, 2023 •

edited