feat(indy-vdr)!: extend did:indy support #1362

TimoGlastra · 2023-03-02T13:26:35Z

Same changes as in #1347, but now for indy-vdr.

It updates the anoncreds registry to support both legacy and did:indy identifiers.

There's one issue that needs to be resolved, but I'd like to do that in a separate PR, is that currently the code isn't set up in a way yet that we support using both did:indy and legacy identifiers in anoncreds for issuance. As the holder and verifier only do resolving, it works with both now.

What still needs to be done:

when a credential with legacy identifiers or vice versa is received, allow it to be shared as the other format. I want to store all credentials using the new did:indy identifiers, and we can optionally transform the identifiers to legacy when needed (in the credential/proof format services)
creating an offer for legacy format as the record always stores using the did:indy format. I'd also like to handle this in the format services, so the storage / issuer/holder/verifier services always use the new formats.

Signed-off-by: Timo Glastra <timo@animo.id>

…t-foundation#1314) Signed-off-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: Agent default outbound content type has been changed to DIDComm V1. If you want to use former behaviour, you can do it so by manually setting `didcommMimeType` in `Agent`'s init config: ``` const agent = new Agent({ config: { ... didCommMimeType: DidCommMimeType.V0 }, ... }) ```

…ion#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com>

Signed-off-by: Timo Glastra <timo@animo.id>

…-did-support

Signed-off-by: Timo Glastra <timo@animo.id>

…did-support

packages/indy-sdk/src/anoncreds/utils/identifiers.ts

+export function parseRevocationRegistryId(revocationRegistryId: string) {
+  const match =
+    revocationRegistryId.match(didIndyRevocationRegistryIdRegex) ??
+    revocationRegistryId.match(legacyIndyRevocationRegistryIdRegex)


packages/indy-vdr/src/anoncreds/utils/identifiers.ts

+export function parseRevocationRegistryId(revocationRegistryId: string) {
+  const match =
+    revocationRegistryId.match(didIndyRevocationRegistryIdRegex) ??
+    revocationRegistryId.match(legacyIndyRevocationRegistryIdRegex)


…did-support

Signed-off-by: Timo Glastra <timo@animo.id>

codecov-commenter · 2023-03-03T16:49:58Z

Codecov Report

Merging #1362 (294de2c) into main (c133538) will increase coverage by 2.10%.
The diff coverage is 72.41%.

@@            Coverage Diff             @@
##             main    #1362      +/-   ##
==========================================
+ Coverage   70.85%   72.96%   +2.10%     
==========================================
  Files         694      694              
  Lines       16692    16717      +25     
  Branches     2861     2864       +3     
==========================================
+ Hits        11827    12197     +370     
+ Misses       4862     4517     -345     
  Partials        3        3

Impacted Files	Coverage Δ
packages/core/src/storage/Repository.ts	`86.95% <0.00%> (-1.94%)`	⬇️
packages/core/src/storage/RepositoryEvents.ts	`100.00% <ø> (ø)`
...sdk/src/anoncreds/services/IndySdkIssuerService.ts	`22.91% <0.00%> (ø)`
...ackages/indy-sdk/src/dids/IndySdkSovDidResolver.ts	`15.38% <0.00%> (-53.04%)`	⬇️
...ackages/indy-vdr/src/dids/IndyVdrSovDidResolver.ts	`15.78% <0.00%> (-61.72%)`	⬇️
...indy-vdr/src/anoncreds/IndyVdrAnonCredsRegistry.ts	`56.29% <70.45%> (-24.69%)`	⬇️
...ckages/indy-vdr/src/anoncreds/utils/identifiers.ts	`80.00% <77.77%> (-20.00%)`	⬇️
...kages/indy-vdr/src/dids/IndyVdrIndyDidRegistrar.ts	`79.12% <78.78%> (+70.78%)`	⬆️
...ckages/indy-vdr/src/dids/IndyVdrIndyDidResolver.ts	`77.08% <82.35%> (+65.76%)`	⬆️
packages/indy-vdr/src/pool/IndyVdrPoolService.ts	`76.31% <83.33%> (+3.94%)`	⬆️
... and 49 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

genaris

Left some minor comments / questions but LGTM!!!

genaris · 2023-03-06T00:56:46Z

packages/indy-sdk/src/dids/IndySdkIndyDidRegistrar.ts

@@ -313,3 +311,15 @@ export interface IndySdkIndyDidCreateOptions extends DidCreateOptions {
    privateKey?: Buffer
  }
 }
+
+interface IndySdkIndyDidCreateOptionsWithDid extends IndySdkIndyDidCreateOptionsBase {
+  method?: never


This is a very interesting approach to prevent some frustrating errors at runtime. I think it can be extended to general DidsApi DidCreateOptions.

Or maybe method can be omitted in DidRegistrars XXXDidCreateOptions (as it is redundant if you are calling directly to the registrar).

Yeah removing it makes sense. I'd like to do that in a separate PR if that's okay as it spans all did registrars

packages/indy-vdr/src/anoncreds/IndyVdrAnonCredsRegistry.ts

genaris · 2023-03-06T01:32:32Z

packages/indy-vdr/src/anoncreds/IndyVdrAnonCredsRegistry.ts

      const response = await pool.submitReadRequest(request)

-      const schema = await this.fetchIndySchemaWithSeqNo(agentContext, response.result.ref, did)
+      // We need to fetch the schema to determine the schemaId (we only have the seqNo)
+      const schema = await this.fetchIndySchemaWithSeqNo(agentContext, response.result.ref, didIdentifier)


Would it make sense for AnonCredsRegistrars to first check in the AnonCredsSchemaRepository so no extra transaction is required? And also store it after retrieving? Or this is something that should be done in AnonCredsApi level?

This is not strictly related to this PR but was something that felt a bit awkward when doing integration with AATH.

We could check in the schema repository. I'm not sure about storing it as the records are for things this agent created, not for just any schema record.

I think not having to fetch the schema is something we could solve using the cache.

We can't actually look at the schemaRecord as we don't store the seqNo. We should probably add it to the metadata, but I wanted to have as little indy specific logic as possible.

I'll address this in a follow up PR

Good point! Of course not needed for this PR, just some thinking that came up to my head while reviewing this one.

packages/indy-vdr/src/dids/IndyVdrIndyDidRegistrar.ts

genaris · 2023-03-06T01:51:25Z

packages/indy-vdr/src/dids/IndyVdrIndyDidRegistrar.ts


-      agentContext.config.logger.debug(`Registered public did '${targetDid}' on ledger '${pool.indyNamespace}'`, {
+      agentContext.config.logger.debug(`Registered public did '${unqualifiedDid}' on ledger '${pool.indyNamespace}'`, {


Do you think it could be convenient to log using the full did format? Aligned with the way we are logging ledger objects in AnonCredsRegistry

Yeah that would be convenient, but it means we need to pass either both the qualified and unqualified did or parse it again (which as overhead).

What's your preference?

Oh I see.. I think it's OK to use the unqualified in that case. Maybe not calling it a 'public did' but simply id or namespace id. But again, it's just some nitpicking here.

Signed-off-by: Timo Glastra <timo@animo.id>

commit 0351eec Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 15 12:02:50 2023 -0300 fix: connection id in sessions for new connections (openwallet-foundation#1383) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit f27fb99 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 15 09:23:10 2023 -0300 feat: basic message pthid/thid support (openwallet-foundation#1381) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit d59366a Author: Jim Ezesinachi <ezesinachijim@gmail.com> Date: Wed Mar 15 11:04:52 2023 +0100 docs: fix example usage of indy-sdk-react-native package (openwallet-foundation#1382) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit a4204ef Author: Timo Glastra <timo@animo.id> Date: Sat Mar 11 16:31:09 2023 +0100 fix: remove named capture groups (openwallet-foundation#1378) named capture groups are only supported in more recent versions of hermes Signed-off-by: Timo Glastra <timo@animo.id> commit dd6c020 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Mar 11 11:57:37 2023 -0300 feat(anoncreds-rs): use new API methods for json conversion (openwallet-foundation#1373) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 122cdde Author: Timo Glastra <timo@animo.id> Date: Sat Mar 11 13:31:09 2023 +0100 fix: return HTTP 415 if unsupported content type (openwallet-foundation#1313) Signed-off-by: Timo Glastra <timo@animo.id> commit 582c711 Author: Mo <10432473+morrieinmaas@users.noreply.github.com> Date: Sat Mar 11 12:08:02 2023 +0100 feat: outbound message send via session (openwallet-foundation#1335) Co-authored-by: Jim Ezesinachi <ezesinachijim@gmail.com> Co-authored-by: Timo Glastra <timo@animo.id> Signed-off-by: Moriarty <moritz@animo.id> commit 19cefa5 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Mar 11 07:20:49 2023 -0300 feat(askar): import/export wallet support for SQLite (openwallet-foundation#1377) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c72ba14 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 17:40:03 2023 +0100 fix(askar): custom error handling (openwallet-foundation#1372) Signed-off-by: Timo Glastra <timo@animo.id> commit 39c4ed0 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 16:52:12 2023 +0100 feat(indy-vdr)!: extend did:indy support (openwallet-foundation#1362) Signed-off-by: Timo Glastra <timo@animo.id> commit 01669a7 Author: Timo Glastra <timo@animo.id> Date: Wed Mar 8 14:48:34 2023 +0100 test: increase timeout to 120 seconds (openwallet-foundation#1375) Signed-off-by: Timo Glastra <timo@animo.id> commit 953069a Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Mar 6 10:28:30 2023 -0300 fix(core): repository event when calling deleteById (openwallet-foundation#1356) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c133538 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Mar 6 08:26:42 2023 -0300 fix(anoncreds): Buffer not imported from core (openwallet-foundation#1367) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 8f6b344 Author: Timo Glastra <timo@animo.id> Date: Fri Mar 3 12:15:58 2023 +0100 feat(indy-sdk)!: move to did:indy with limited support (openwallet-foundation#1347) Signed-off-by: Timo Glastra <timo@animo.id> commit 7795975 Author: Martin Auer <martin.auer97@gmail.com> Date: Fri Mar 3 11:07:43 2023 +0100 fix(tenant): Correctly configure storage for multi tenant agents (openwallet-foundation#1359) Fixes hyperledger#1353 Signed-off-by: martin auer <martin.auer97@gmail.com> commit cb4e469 Author: Timo Glastra <timo@animo.id> Date: Thu Mar 2 22:38:14 2023 +0100 test: various improvements (openwallet-foundation#1361) Signed-off-by: Timo Glastra <timo@animo.id> commit fd13bb8 Author: Ariel Gentile <gentilester@gmail.com> Date: Thu Mar 2 17:00:57 2023 -0300 feat(oob): implicit invitations (openwallet-foundation#1348) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 18abb18 Author: Pritam Singh <43764373+Zzocker@users.noreply.github.com> Date: Thu Mar 2 22:11:20 2023 +0530 fix: isNewSocket logic (openwallet-foundation#1355) Signed-off-by: Pritam Singh <pkspritam16@gmail.com> commit 2c792fe Author: Martin Auer <martin.auer97@gmail.com> Date: Thu Mar 2 14:29:05 2023 +0100 refactor!: remove getKeyDidMappingByVerificationMethod (openwallet-foundation#1350) Signed-off-by: martin auer <martin.auer97@gmail.com> commit 78ecf1e Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Mar 1 18:44:26 2023 -0300 refactor!: remove Dispatcher.registerMessageHandler (openwallet-foundation#1354) BREAKING CHANGE: `Dispatcher.registerMessageHandler` has been removed in favour of `MessageHandlerRegistry.registerMessageHandler`. If you want to register message handlers in an extension module, you can use directly `agentContext.dependencyManager.registerMessageHandlers`. Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 1bda3f0 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 27 15:35:16 2023 -0300 fix(anoncreds-rs): save revocation registry index (openwallet-foundation#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 4ab3b54 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 27 13:23:47 2023 +0100 refactor!: set default outbound content type to didcomm v1 (openwallet-foundation#1314) Signed-off-by: Timo Glastra <timo@animo.id> BREAKING CHANGE: Agent default outbound content type has been changed to DIDComm V1. If you want to use former behaviour, you can do it so by manually setting `didcommMimeType` in `Agent`'s init config: ``` const agent = new Agent({ config: { ... didCommMimeType: DidCommMimeType.V0 }, ... }) ``` commit 254f661 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Feb 25 11:49:36 2023 -0300 fix(indy-sdk): import from core (openwallet-foundation#1346) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 21d4bf7 Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 22:20:54 2023 +0100 feat!: allow to import created dids (and remove legacy `publicDidSeed`) (openwallet-foundation#1325) Signed-off-by: Timo Glastra <timo@animo.id> commit dc60acb Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 20:50:28 2023 +0100 build(anoncreds): remove node package from deps (openwallet-foundation#1339) Signed-off-by: Timo Glastra <timo@animo.id> commit e14d853 Author: Timo Glastra <timo@animo.id> Date: Fri Feb 24 17:59:30 2023 +0100 test: increase indy-sdk timeout (openwallet-foundation#1345) Signed-off-by: Timo Glastra <timo@animo.id> commit d38ecb1 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 24 09:12:40 2023 -0300 fix(anoncreds): include prover_did for legacy indy (openwallet-foundation#1342) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit da8f2ad Author: Niall Shaw <100220424+niall-shaw@users.noreply.github.com> Date: Fri Feb 24 13:01:47 2023 +0200 fix: create new socket if socket state is 'closing' (openwallet-foundation#1337) Signed-off-by: Niall Shaw <niall.shaw@absa.africa> commit cac2ec3 Author: Martin Auer <martin.auer97@gmail.com> Date: Fri Feb 24 11:11:28 2023 +0100 refactor(core)!: remove deprecated injectionContainer prop (openwallet-foundation#1344) Signed-off-by: martin auer <martin.auer97@gmail.com> commit d5e34ff Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 24 06:19:32 2023 -0300 test(indy-sdk): wait before resolving ledger objects (openwallet-foundation#1340) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 518e5e4 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Feb 22 04:36:33 2023 -0300 fix: expose indy pool configs and action menu messages (openwallet-foundation#1333) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 1c6aeae Author: Ariel Gentile <gentilester@gmail.com> Date: Tue Feb 21 19:18:19 2023 -0300 fix(askar): anoncrypt messages unpacking (openwallet-foundation#1332) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit fb7ee50 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Tue Feb 21 15:39:14 2023 +0100 feat: IndyVdrAnonCredsRegistry revocation methods (openwallet-foundation#1328) Signed-off-by: Victor Anene <victor@animo.id> commit 64e20f1 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 17:07:30 2023 +0100 fix!: don't emit legacy did:sov prefix for new protocols (openwallet-foundation#1245) Signed-off-by: Timo Glastra <timo@animo.id> commit c0e5339 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 20 09:04:20 2023 -0300 fix: seed and private key validation and return type in registrars (openwallet-foundation#1324) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit edf392f Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 12:14:21 2023 +0100 refactor: remove master secret id from wallet (openwallet-foundation#1320) Signed-off-by: Timo Glastra <timo@animo.id> commit b6d66b1 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 20 00:59:42 2023 +0100 refactor!: remove indy from core (openwallet-foundation#1286) Signed-off-by: Timo Glastra <timo@animo.id> commit 616b908 Author: Ariel Gentile <gentilester@gmail.com> Date: Sun Feb 19 13:27:16 2023 -0300 feat(wallet)!: createKey from private key (openwallet-foundation#1301) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 64a5da9 Author: Ariel Gentile <gentilester@gmail.com> Date: Sat Feb 18 16:54:25 2023 -0300 fix(samples): dummy module response message type (openwallet-foundation#1321) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit ff5596d Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 17 23:10:09 2023 -0300 feat!: add data, cache and temp dirs to FileSystem (openwallet-foundation#1306) Signed-off-by: Ariel Gentile <gentilester@gmail.com> BREAKING CHANGE: Agent-produced files will now be divided in different system paths depending on their nature: data, temp and cache. Previously, they were located at a single location, defaulting to a temporary directory. If you specified a custom path in `FileSystem` object constructor, you now must provide an object containing `baseDataPath`, `baseTempPath` and `baseCachePath`. They can point to the same path, although it's recommended to specify different path to avoid future file clashes. commit af384e8 Author: Timo Glastra <timo@animo.id> Date: Sat Feb 18 01:32:45 2023 +0100 fix: loosen base64 validation (openwallet-foundation#1312) Signed-off-by: Timo Glastra <timo@animo.id> commit 229ed1b Author: Timo Glastra <timo@animo.id> Date: Fri Feb 17 21:31:47 2023 +0100 fix: thread id improvements (openwallet-foundation#1311) Signed-off-by: Timo Glastra <timo@animo.id> commit 1d782f5 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Fri Feb 17 20:01:35 2023 +0100 feat: add fetch indy schema method (openwallet-foundation#1290) Signed-off-by: Victor Anene <victor@animo.id> commit 3e02227 Author: Ariel Gentile <gentilester@gmail.com> Date: Wed Feb 15 20:14:47 2023 -0300 fix: imports from core (openwallet-foundation#1303) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 4ac5332 Author: Jason C. Leach <jason.leach@fullboar.ca> Date: Wed Feb 15 14:11:41 2023 -0800 feat: add devcontainer support (openwallet-foundation#1282) Signed-off-by: Jason C. Leach <jason.leach@fullboar.ca> commit efab8dd Author: Ariel Gentile <gentilester@gmail.com> Date: Tue Feb 14 19:49:59 2023 -0300 feat(indy-vdr): resolver and registrar for did:indy (openwallet-foundation#1253) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit a487705 Author: Timo Glastra <timo@animo.id> Date: Tue Feb 14 10:57:22 2023 +0100 docs: update readme (openwallet-foundation#1298) docs: update reaadme Signed-off-by: Timo Glastra <timo@animo.id> commit ecce0a7 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 13 19:01:39 2023 -0300 fix(askar): generate nonce suitable for anoncreds (openwallet-foundation#1295) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit c63350c Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 20:58:46 2023 +0100 test: add anoncreds restriction test (openwallet-foundation#1294) Signed-off-by: Timo Glastra <timo@animo.id> commit b570e0f Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 19:49:21 2023 +0100 fix(indy-vdr): export relevant packages from root (openwallet-foundation#1291) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit c72fd74 Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 18:40:44 2023 +0100 feat(anoncreds): legacy indy proof format service (openwallet-foundation#1283) Signed-off-by: Timo Glastra <timo@animo.id> commit dfb3eaf Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 16:23:41 2023 +0100 build(indy-sdk): set private to false (openwallet-foundation#1293) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit 231145f Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 13 10:22:44 2023 -0300 chore: make askar, anoncreds(-rs), indy-vdr packages public (openwallet-foundation#1292) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit fb8d58b Author: Timo Glastra <timo@animo.id> Date: Mon Feb 13 12:57:35 2023 +0100 refactor(proofs)!: generalize proofs api and improve consistency with credentials module (openwallet-foundation#1279) Signed-off-by: Timo Glastra <timo@animo.id> commit 51030d4 Author: Karim Stekelenburg <karim@animo.id> Date: Mon Feb 13 11:43:02 2023 +0100 feat(indy-vdr): module registration (openwallet-foundation#1285) Signed-off-by: Karim Stekelenburg <karim@animo.id> commit d61f6ed Author: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Date: Mon Feb 13 09:23:17 2023 +0100 chore(core): remove useless file (openwallet-foundation#1288) commit 30857b9 Author: Berend Sliedrecht <61358536+blu3beri@users.noreply.github.com> Date: Sat Feb 11 22:50:10 2023 +0100 fix(transport)!: added docs moved connection to connectionId (openwallet-foundation#1222) Signed-off-by: blu3beri <blu3beri@proton.me> commit efe0271 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 10 19:15:36 2023 -0300 feat: add anoncreds-rs package (openwallet-foundation#1275) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 2669d7d Author: KolbyRKunz <KolbyKunz@yahoo.com> Date: Fri Feb 10 14:14:59 2023 -0700 fix: set updateAt on records when updating a record (openwallet-foundation#1272) Signed-off-by: KolbyRKunz <kolbykunz@yahoo.com> commit 1d487b1 Author: Jim Ezesinachi <jim@animo.id> Date: Fri Feb 10 20:21:20 2023 +0100 feat: added endpoint setter to agent InitConfig (openwallet-foundation#1278) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit 86cb9d0 Author: Ariel Gentile <gentilester@gmail.com> Date: Fri Feb 10 11:13:44 2023 -0300 ci: increase maximum heap memory for node (openwallet-foundation#1280) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit d056316 Author: Victor Anene <62852943+Vickysomtee@users.noreply.github.com> Date: Fri Feb 10 01:31:43 2023 +0100 feat(indy-vdr): add IndyVdrAnonCredsRegistry (openwallet-foundation#1270) Signed-off-by: Timo Glastra <timo@animo.id> commit f18d189 Author: Ariel Gentile <gentilester@gmail.com> Date: Mon Feb 6 23:34:21 2023 -0300 feat: add initial askar package (openwallet-foundation#1211) Signed-off-by: Ariel Gentile <gentilester@gmail.com> commit 115d897 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Feb 6 23:45:01 2023 +0000 build(deps): bump http-cache-semantics from 4.1.0 to 4.1.1 (openwallet-foundation#1258) commit 3d86e78 Author: Karim Stekelenburg <karim@animo.id> Date: Tue Feb 7 00:09:24 2023 +0100 feat(openid4vc-client): pre-authorized (openwallet-foundation#1243) This PR adds support for the `pre-authorized` OpenID for Verifiable Credentials issuance flow to the new `openid4vc-client` module. Here are some highlights of the work: - Allows the user to execute the entire `pre-authorized` flow by calling a single method. - Adds a happy-flow test - HTTP(S) requests and responses are mocked using a network mocking library called [nock](https://github.com/nock/nock) - Because the JSON-LD credential that is received is expanded by the `W3cCredentialService`, I've added a few new contexts to our test document loader. - Not-so-happy-flow tests will be added later on. If you have any suggestions for edge cases that deserve testing, feel free to drop a comment. - Modifies the `JwsService` - The `JwsService` was geared towards a very specific use case. I've generalized its API so it's usable for a wider range of applications. - All pre-existing tests and calls to the `JwsService` have been updated. It's worth noting that I have had to add some `@ts-ignore` statements here and there to get around some incomplete types in the `OpenID4VCI-Client` library we're using. Once these issues have been resolved in the client library, they will be removed. **Work funded by the government of Ontario** --------- Signed-off-by: Karim Stekelenburg <karim@animo.id> Co-authored-by: Timo Glastra <timo@animo.id> commit 7f65ba9 Author: Jim Ezesinachi <jim@animo.id> Date: Mon Feb 6 22:27:03 2023 +0100 feat: optional routing for legacy connectionless invitation (openwallet-foundation#1271) Signed-off-by: Jim Ezesinachi <jim@animo.id> commit 3a4c5ec Author: Timo Glastra <timo@animo.id> Date: Mon Feb 6 21:49:12 2023 +0100 feat(anoncreds): add anoncreds API (openwallet-foundation#1232) Signed-off-by: Timo Glastra <timo@animo.id>

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra and others added 9 commits February 25, 2023 16:22

feat(indy-sdk)!: full did:indy support

0e81028

Signed-off-by: Timo Glastra <timo@animo.id>

fix: broken tests

333b185

Signed-off-by: Timo Glastra <timo@animo.id>

temp

33d87bf

Signed-off-by: Timo Glastra <timo@animo.id>

fix(anoncreds-rs): save revocation registry index (openwallet-foundat…

0dba4b9

…ion#1351) Signed-off-by: Ariel Gentile <gentilester@gmail.com>

chore: address feedback

128a817

Signed-off-by: Timo Glastra <timo@animo.id>

Merge branch 'feat/indy-sdk-indy-did-support' into feat/indy-vdr-indy…

bec3ece

…-did-support

fix: did indy support for indy-vdr

c8bb89e

Signed-off-by: Timo Glastra <timo@animo.id>

Merge remote-tracking branch 'upstream/main' into feat/indy-vdr-indy-…

45f3e4c

…did-support

TimoGlastra requested a review from a team as a code owner March 2, 2023 13:26

github-advanced-security bot found potential problems Mar 2, 2023

View reviewed changes

Merge remote-tracking branch 'upstream/main' into feat/indy-vdr-indy-…

c5bb653

…did-support

TimoGlastra requested a review from genaris March 3, 2023 16:26

style: eslint fixes

d39c2c2

Signed-off-by: Timo Glastra <timo@animo.id>

genaris approved these changes Mar 6, 2023

View reviewed changes

TimoGlastra mentioned this pull request Mar 6, 2023

Would it make sense for AnonCredsRegistrars to first check in the AnonCredsSchemaRepository so no extra transaction is required? And also store it after retrieving? Or this is something that should be done in AnonCredsApi level? #1368

Open

TimoGlastra requested a review from genaris March 6, 2023 15:14

Merge branch 'main' into feat/indy-vdr-indy-did-support

c99b3be

genaris approved these changes Mar 6, 2023

View reviewed changes

namespace identifier

864db32

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra enabled auto-merge (squash) March 7, 2023 13:32

first write to prevent timing issue

399367d

Signed-off-by: Timo Glastra <timo@animo.id>

TimoGlastra disabled auto-merge March 8, 2023 11:57

TimoGlastra enabled auto-merge (squash) March 8, 2023 11:57

TimoGlastra added 2 commits March 8, 2023 13:06

chore: update indy-vdr

294de2c

Signed-off-by: Timo Glastra <timo@animo.id>

Merge branch 'main' into feat/indy-vdr-indy-did-support

597a377

TimoGlastra merged commit 39c4ed0 into openwallet-foundation:main Mar 8, 2023

karimStekelenburg pushed a commit to karimStekelenburg/aries-framework-javascript that referenced this pull request Mar 17, 2023

feat(indy-vdr)!: extend did:indy support (openwallet-foundation#1362)

a9ce47f

Signed-off-by: Timo Glastra <timo@animo.id>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(indy-vdr)!: extend did:indy support #1362

feat(indy-vdr)!: extend did:indy support #1362

TimoGlastra commented Mar 2, 2023

codecov-commenter commented Mar 3, 2023 •

edited

genaris left a comment

genaris Mar 6, 2023

TimoGlastra Mar 6, 2023

genaris Mar 6, 2023

TimoGlastra Mar 6, 2023

TimoGlastra Mar 6, 2023

genaris Mar 6, 2023

genaris Mar 6, 2023

TimoGlastra Mar 6, 2023

genaris Mar 6, 2023


		agentContext.config.logger.debug(`Registered public did '${targetDid}' on ledger '${pool.indyNamespace}'`, {
		agentContext.config.logger.debug(`Registered public did '${unqualifiedDid}' on ledger '${pool.indyNamespace}'`, {

feat(indy-vdr)!: extend did:indy support #1362

feat(indy-vdr)!: extend did:indy support #1362

Conversation

TimoGlastra commented Mar 2, 2023

codecov-commenter commented Mar 3, 2023 • edited

Codecov Report

genaris left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-commenter commented Mar 3, 2023 •

edited