Add icon url to currency (closes #1449) #1465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shal
changed the title
shal
changed the title
ysv
suggested changes
Jul 23, 2018
app/models/currency.rb
Outdated
| @@ -202,6 +202,7 @@ def disabled? | |||
| # precision :integer default(8), not null | |||
| # created_at :datetime not null | |||
| # updated_at :datetime not null | |||
| # icon_url :string(255) | |||
There was a problem hiding this comment.
Place icon_url after precision
Add default value
Add validation url: { allow_blank: true }
app/helpers/currency_helper.rb
Outdated
| private | ||
|
|
||
| def coin_icon_url(currency) | ||
| currency.icon_url || "yarn_components/cryptocurrency-icons/svg/color/#{currency.code}.svg" |
There was a problem hiding this comment.
I think more safe will be to use
if currency.icon_url.blank?
calj
approved these changes
Jul 30, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.