Add caching for the most used public endpoints #2625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnaichuk
force-pushed
the
enhancement/cache-public-endpoints
branch
from
565b9c3
to
883078f
Compare
|
Hey, I suggest using model caching for common models like Currency, Market, etc. This way we can update cache when the model is updated. |
mnaichuk
force-pushed
the
enhancement/cache-public-endpoints
branch
3 times, most recently
from
380af75
to
97b46f8
Compare
I will use model callbacks to wipe the cache after commit. |
mnaichuk
force-pushed
the
enhancement/cache-public-endpoints
branch
from
97b46f8
to
d161f61
Compare
mod
approved these changes
Jun 24, 2020
chumaknadya
pushed a commit
that referenced
this pull request
Jul 28, 2020
chumaknadya
pushed a commit
that referenced
this pull request
Jul 28, 2020
chumaknadya
pushed a commit
that referenced
this pull request
Jul 28, 2020
chumaknadya
pushed a commit
that referenced
this pull request
Jul 28, 2020
mnaichuk
pushed a commit
that referenced
this pull request
Jul 31, 2020
mod
pushed a commit
that referenced
this pull request
Aug 1, 2020
* Add caching for the most used public endpoints (#2625) * Fix format function in TickersJob * Remove inqury from TradingFee model * Feature: expose maker & taker fee for order entity (#2627) * Add rake task for distribution (#2631) * Add rake task for distribution * InfluxDB sharding * Feature: Add redis cluster support * Fix influxdb spec for 50008 seed * Rewrite deposit collection flow (#2636) * Remove amqp publish and add new deposit state * Remove amqp deposit workers * Remove rspec stubs for amqp deposit workers * Improve deposit daemon * Remove amqp deposit daemons specs * fee_process! if transactions present * Improve deposit collection flow * Improve error handling * Update wallet search for the deposit * Add deposit collection flow documentation * Add support for multiple influxdb hosts in config * Improve market states for api Co-authored-by: Valera Petrusenko <villi1511@gmail.com>
mnaichuk
pushed a commit
that referenced
this pull request
Aug 1, 2020
mod
pushed a commit
that referenced
this pull request
Aug 1, 2020
* Add caching for the most used public endpoints (#2625) * Remove inqury from TradingFee model * Fix /currencies and /markets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.