-
-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add basic svg element #279
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XGHeaven
force-pushed
the
feat/svg-element
branch
3 times, most recently
from
March 12, 2023 13:33
b09fb46
to
3fb2802
Compare
XGHeaven
force-pushed
the
feat/svg-element
branch
from
March 29, 2023 16:29
3fb2802
to
a1ee468
Compare
andycall
reviewed
Mar 30, 2023
XGHeaven
force-pushed
the
feat/svg-element
branch
3 times, most recently
from
April 5, 2023 15:18
2cb5647
to
6b16fba
Compare
XGHeaven
force-pushed
the
feat/svg-element
branch
3 times, most recently
from
April 17, 2023 16:30
975f852
to
2c95a19
Compare
XGHeaven
force-pushed
the
feat/svg-element
branch
2 times, most recently
from
April 26, 2023 14:24
8c7bbf7
to
5049928
Compare
XGHeaven
changed the title
[WIP] feat: add basic svg element
feat: add basic svg element
Apr 27, 2023
andycall
reviewed
Apr 27, 2023
andycall
reviewed
Apr 27, 2023
XGHeaven
force-pushed
the
feat/svg-element
branch
5 times, most recently
from
May 1, 2023 12:05
4d67adc
to
1d32e9c
Compare
andycall
reviewed
May 8, 2023
andycall
reviewed
May 8, 2023
Support the basic usage of svg to render icon. More implements will be add in the future. - SVG element support presentation attributes - New style add - [x] `fill` (partial test) - [x] `stroke` (partial test) - [x] `x` (non test) - [x] `y` (non test) - [x] `fill-rule` (full test with `<path>`) - [x] `stroke-width` (partial test) - [x] `stroke-linecap` (full test with `<path>`) - [x] `stroke-linejoin` (full test with `<path>`) - Element - [x] `<svg>` (non tests, added in the future) - [x] `<rect>` (partial tests, just used for test <path>) - [x] `<path>` - [x] `d` full test - [x] `<text>` (non tests, added in the future) - [x] `<g>` (non tests, added in the future) - DOM Interface (non tests, just a empty class) - [x] `SVGElement` - [x] `SVGRectElement` - [x] `SVGGElement` - [x] `SVGTextElement` - [x] `SVGPathElement` - [x] And other super classess.. - Integration Test - [x] Add SVG spec group. - [x] Add `svg_loader` to compile svg test file. - [x] Add `resizeViewport` function to resize the viewport. Because some svg test file needs the larger viewport. - [x] `toMatchSnapshot` support accept blob file to compare. No png file generated. - [x] Add `getSnapshot`/`cacheSnapshot`/`matchCacheSnapshot` function to implement compare the snapshots of two frame.
1 task
andycall
approved these changes
May 13, 2023
xuzhongpeng
approved these changes
May 14, 2023
xuzhongpeng
approved these changes
May 14, 2023
xuzhongpeng
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support the basic usage of svg to render icon.
More implements will be add in the future.
fill
(partial test)stroke
(partial test)x
(non test)y
(non test)fill-rule
(full test with<path>
)stroke-width
(partial test)stroke-linecap
(full test with<path>
)stroke-linejoin
(full test with<path>
)<svg>
(non tests, added in the future)<rect>
(partial tests, just used for test )<path>
d
full test<text>
(non tests, added in the future)<g>
(non tests, added in the future)SVGElement
SVGRectElement
SVGGElement
SVGTextElement
SVGPathElement
svg_loader
to compile svg test file.resizeViewport
function to resize the viewport.Because some svg test file needs the larger viewport.
toMatchSnapshot
support accept blob file to compare.No png file generated.
getSnapshot
/cacheSnapshot
/matchCacheSnapshot
functionto implement compare the snapshots of two frame.