Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix crashed when running in multiple flutter engine instance. #377

Merged
merged 2 commits into from
Jun 6, 2023
Merged

fix: fix crashed when running in multiple flutter engine instance. #377

merged 2 commits into from
Jun 6, 2023

Conversation

andycall
Copy link
Member

@andycall andycall commented Jun 4, 2023 •
edited
Loading

  1. Merge DartContext and DartIsolateContext into one entity, with multiple DartIsolateContexts in a single thread sharing a JSRuntime.
  2. Make all instances of the global AtomicString thread_local to maintain separate copies and avoid conflicts across multiple threads.

@andycall andycall requested a review from ErosZy June 6, 2023 05:15
@andycall andycall added this pull request to the merge queue Jun 6, 2023
Merged via the queue into main with commit 93281f2 Jun 6, 2023
@andycall andycall deleted the fix/multiple_page_crash branch June 6, 2023 08:29
@andycall andycall self-assigned this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErosZy ErosZy ErosZy approved these changes

@yifei8 yifei8 yifei8 approved these changes

Assignees

@andycall andycall

Labels
None yet
Projects
80% Completion Progresses
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andycall @ErosZy @yifei8