fix: avoiding trigger touch events to inaccessible dom elements. #517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
looseyi
approved these changes
Nov 7, 2023
Ivan-young66
approved these changes
Nov 7, 2023
andycall
added a commit
that referenced
this pull request
Nov 18, 2023
The target element of a Touch object may be reclaimed by the JavaScript garbage collector, causing it to become invisible and inaccessible. This update introduces checks to prevent the triggering of events on these invisible DOM targets. <img width="892" alt="image" src="https://github.com/openwebf/webf/assets/4409743/4db7d025-3114-4d5a-8587-31cfa7f06ae6">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The target element of a Touch object may be reclaimed by the JavaScript garbage collector, causing it to become invisible and inaccessible.
This update introduces checks to prevent the triggering of events on these invisible DOM targets.