Permalink
Browse files

Coverity issues bug fixes

:Release Notes:
Coverity issues bug fixes

:Detailed Notes:
Fixed argument mismatch in LOG_ERROR.
class variable m_complete initialized in
class constructor.

:Testing Performed:
Compiled locally and tested on official build.

:QA Notes:

:Issues Addressed:
[GF-52993] ActivityManager - Coverity issues
Open-webOS-DCO-1.0-Signed-off-by: ashish.sadre <ashish.sadre@lge.com>

Change-Id: I7f3e4bb925c052e4749909f12bf45f552ee7780e
Reviewed-on: https://g2g.palm.com/4049
Reviewed-by: DCO Verification
Reviewed-by: Ashish Sadre <ashish.sadre@lge.com>
Tested-by: Ashish Sadre <ashish.sadre@lge.com>
Reviewed-by: Maksym Sditanov <maxim.sditanov@lge.com>
Tested-by: Maksym Sditanov <maxim.sditanov@lge.com>
  • Loading branch information...
1 parent 3aa89f3 commit 9c299d0c747e792138cf736159d85719f08b928b ashish.sadre committed with Maksym Sditanov Nov 26, 2013
Showing with 3 additions and 2 deletions.
  1. +1 −0 src/Callback.cpp
  2. +2 −2 src/MojoPersistCommand.cpp
View
1 src/Callback.cpp
@@ -24,6 +24,7 @@ MojLogger Callback::s_log(_T("activitymanager.callback"));
Callback::Callback(boost::shared_ptr<Activity> activity)
: m_serial(UnassignedSerial)
, m_activity(activity)
+ , m_complete(false)
{
}
View
4 src/MojoPersistCommand.cpp
@@ -67,8 +67,8 @@ void MojoPersistCommand::Persist()
&MojoPersistCommand::PersistResponse, m_service, m_method, params);
m_call->Call();
} catch (const std::exception& except) {
- LOG_ERROR(MSGID_PERSIST_ATMPT_UNEXPECTD_EXCPTN, 2, PMLOGKFV("activity","%llu",m_activity->GetId()),
- PMLOGKS("Persist_command",GetString().c_str()),PMLOGKS("Exception",except.what()),
+ LOG_ERROR(MSGID_PERSIST_ATMPT_UNEXPECTD_EXCPTN, 3, PMLOGKFV("activity","%llu",m_activity->GetId()),
+ PMLOGKS("Persist_command",GetString().c_str()), PMLOGKS("Exception",except.what()),
"Unexpected exception while attempting to persist");
Complete(false);
} catch (...) {

0 comments on commit 9c299d0

Please sign in to comment.