Add protecting <div> around the geogebra object. #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ipt modifies the style of the second enveloping <div> containing the geogebra object. Specifically it sets the height and width. If the <div> contains other material besides the geogebra object these values for the height and width will be incorrect causing overlapping outputs.
|
This a small fix, but it should compensate for apparent changes in the geogebra site code for geogebra HTML5 applets |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hot fix.
The geogebra javaScript modifies the style of the second enveloping <div> containing the geogebra object. Specifically it sets the height and width. If the <div> contains other material besides the geogebra object these values for the height and width will be incorrect causing overlapping outputs.
This fixes the display problems discussed in the forum at
http://webwork.maa.org/moodle/mod/forum/discuss.php?d=4401