fix(logs): Reduce amount of logging in production (#363)

Cf [datadog log patterns](https://app.datadoghq.com/logs/patterns?from_ts=1596789163038&index=&live=true&stream_sort=desc&to_ts=1599381163038): ![image](https://user-images.githubusercontent.com/531781/92321712-6b70c000-f02c-11ea-81b0-37d98639a1f9.png)
openwhyd · Sep 6, 2020 · 4b5efce · 4b5efce
1 parent 85b3f07
commit 4b5efce
Show file tree

Hide file tree

Showing 12 changed files with 19 additions and 15 deletions.
diff --git a/app/controllers/admin/invites.js b/app/controllers/admin/invites.js
@@ -212,7 +212,7 @@ exports.handleRequest = function (request, reqParams, response) {
                   null,
                   { 'content-type': 'text/html' }
                 );
-                console.log('rendering done!');
+                // console.log('rendering done!');
               },
               { sort: [['date', 'desc']] }
             );

diff --git a/app/controllers/collabPl.js b/app/controllers/collabPl.js
@@ -33,7 +33,7 @@ exports.controller = function (request, reqParams, response) {
 
   function render(html) {
     response.renderHTML(html);
-    console.log('rendering done!');
+    // console.log('rendering done!');
     if (
       loggedInUser &&
       loggedInUser.id &&

diff --git a/app/controllers/pgApp.js b/app/controllers/pgApp.js
@@ -165,7 +165,7 @@ exports.controller = function (request, reqParams, response) {
       });
     if (data.html) {
       response.renderHTML(data.html);
-      console.log('rendering done!');
+      // console.log('rendering done!');
       //if (loggedInUser && loggedInUser.id && !reqParams.after && !reqParams.before)
       //	analytics.addVisit(loggedInUser, request.url/*"/u/"+uid*/);
     } else response.legacyRender(data.text || data.json || data.error);

diff --git a/app/controllers/pgGenre.js b/app/controllers/pgGenre.js
@@ -144,7 +144,7 @@ exports.controller = function (request, reqParams, response) {
     if (data.error) console.log('ERROR: ', data.error);
     if (data.html) {
       response.renderHTML(data.html);
-      console.log('rendering done!');
+      // console.log('rendering done!');
       //if (loggedInUser && loggedInUser.id && !reqParams.after && !reqParams.before)
       //	analytics.addVisit(loggedInUser, request.url/*"/u/"+uid*/);
     } else response.legacyRender(data.json || data.error);

diff --git a/app/controllers/recentActivity.js b/app/controllers/recentActivity.js
@@ -192,7 +192,7 @@ exports.controller = function (request, reqParams, response) {
 
   function render(html) {
     response.legacyRender(html, null, { 'content-type': 'text/html' });
-    console.log('rendering done!');
+    // console.log('rendering done!');
     if (
       loggedInUser &&
       loggedInUser.id &&

diff --git a/app/controllers/userLibrary.js b/app/controllers/userLibrary.js
@@ -134,7 +134,7 @@ exports.controller = function (request, reqParams, response) {
       );
     } else if (data.html) {
       response.renderHTML(data.html);
-      console.log('rendering done!');
+      // console.log('rendering done!');
       if (
         loggedInUser &&
         loggedInUser.id &&

diff --git a/app/models/analytics.js b/app/models/analytics.js
@@ -90,12 +90,9 @@ exports.addVisit = function (uId, tId, request) {
     else if (orig.includes('http')) orig = null;
   }
 
-  console.log('analytics.addVisit ', uId, tId, orig);
-
-  var visit = { uId: uId, tId: tId };
+  var visit = { uId, tId };
   if (orig) visit.orig = orig;
 
-  //mongodb.collections["visit"].insertOne(visit, {w:0}); // disabled write concern
   visit._t = new Date().getTime();
   visitStream.write(JSON.stringify(visit) + '\n');
 };
diff --git a/app/models/searchMongo.js b/app/models/searchMongo.js
@@ -157,7 +157,7 @@ exports.topicNameSearch = function (
             //console.log(renderTemplate(q,results));
             //response.legacyRender(util.inspect(results));
             resultHandler(results, q);
-            console.log('search: rendering done!');
+            // console.log('search: rendering done!');
           }
         };
         var timeout = setTimeout(renderer, timeoutDuration);

diff --git a/app/models/track.js b/app/models/track.js
@@ -415,7 +415,14 @@ exports.snapshotTrackScores = function (cb) {
     mongodb.forEach2('track', { fields: { score: 1 } }, function (track, next) {
       if (!track) cb();
       else {
-        console.log('snapshotTrackScores', ++i, '/', count);
+        if (count < 1000) {
+          console.log(`snapshotTrackScores ${i + 1} / ${count}`);
+        } else if (count % 1000 === 0) {
+          console.log(
+            `snapshotTrackScores ${i / 1000}k / ${Math.floor(count / 1000)}k`
+          );
+        }
+        ++i;
         mongodb.collections['track'].update(
           { _id: track._id },
           { $set: { prev: track.score } },

diff --git a/app/models/user.js b/app/models/user.js
@@ -233,7 +233,7 @@ function processUsers(list) {
 }
 
 function fetch(q, handler) {
-  snip.console.log('fetching user ', q, '...');
+  // snip.console.log('fetching user ', q, '...');
   if (q._id && typeof q._id == 'string') q._id = ObjectId(q._id);
   mongodb.collections['user'].findOne(q, function (err, user) {
     if (user) {

diff --git a/app/templates/mainTemplate.js b/app/templates/mainTemplate.js
@@ -378,7 +378,7 @@ exports.renderWhydPage = function (params = {}) {
   ].concat(params.css || []);
 
   var user = params.loggedUser || {};
-  console.log('connected user:', user.name, user.id);
+  // console.log('connected user:', user.name, user.id);
 
   // other recognized params: bodyClass, head, content, sidebar
 

diff --git a/scripts/start.sh b/scripts/start.sh
@@ -12,6 +12,6 @@ fi
 
 # Start new server
 echo "🌄  Starting Openwhyd with WHYD_PORT=$PORT..."
-cd $ROOT_DIR && source env-vars-local.sh && WHYD_PORT=$PORT npm run forever:start &
+cd $ROOT_DIR && source env-vars-local.sh && WHYD_PORT=$PORT npm run forever:start -- --no-color &
 
 # TODO: find a way to identify that instance, e.g. -- "--uid openwhyd_$PORT"