Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old logo from Openwhyd's embed player #183

Closed
adrienjoly opened this issue Dec 1, 2018 · 6 comments
Closed

Replace old logo from Openwhyd's embed player #183

adrienjoly opened this issue Dec 1, 2018 · 6 comments

Comments

@adrienjoly
Copy link
Member

adrienjoly commented Dec 1, 2018

Related to #7.

Example of embed: http://www.musiclikedirt.com/2018/10/12/top-tracks-of-the-month-october-2018/

name of image: /images/logo-verysmall.png (to be replaced by new logo)

@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Dec 1, 2018
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to 📓 Backlog / To Do Next in Development Dec 1, 2018
@namanbiyani
Copy link
Contributor

Hi i want to resolve this bug . Can you please give some guidelines on how to proceed?

@adrienjoly
Copy link
Member Author

Hi! Thank you for offering your help! :-)

Here is some information on how to reproduce the problem:

  1. Go to any Openwhyd playlist, e.g. https://openwhyd.org/u/5228bc3c7e91c862b2b003af/playlist/31
  2. Click on the "Embed" button on the top-right corner of the page

image

As you can see on the screenshot above, a "whyd" logo is displayed in instead of the "Openwhyd" logo.

This logo is loaded because of the #whydPlayer > #whydLogo CSS style from feedEmbedV2.css.

Suggested fix steps:

  1. Make openwhyd run on your own computer (see https://github.com/openwhyd/openwhyd#setup-and-usage)
  2. Replace all references to logo-verysmall.png by logo-white.png
  3. Adjust the the CSS styling of #whydPlayer > #whydLogo so that the embed player looks good. (when testing locally, you may need to create a local openwhyd account and a playlist)
  4. Delete logo-verysmall.png
  5. Commit and make a Pull Request

Let me know if you need more assistance on any of these steps, and/or any question?

Development automation moved this from ⚡️To Do Next to ✔️ Done / pending QA Dec 27, 2018
adrienjoly pushed a commit that referenced this issue Dec 27, 2018
## [1.4.6](v1.4.5...v1.4.6) (2018-12-27)

### Bug Fixes

* **embed:** replace old logo and adjust css styling ([c3865ce](c3865ce)), closes [#183](#183) [#184](#184) [#185](#185)
@adrienjoly
Copy link
Member Author

Thank you for your first contribution to Openwhyd, @namanbiyani! You did great! <3

If you don't mind, in order to make this repository a friendlier to contributors, I'd like to ask you a few questions:

  1. How much experience do you have with contributing to open source projects?
  2. Did you enjoy contributing to Openwhyd? Please explain what was good and what could be improved.
  3. Would you like to contribute to Openwhyd again? If so, can you tell us what kind of contributions your would like to make next.
  4. How did you know about openwhyd.org and/or this open source project?
  5. What motivated you to contribute to Openwhyd?

If you don't feel comfortable replying to these questions here, feel free to respond in private to adrien@openwhyd.org. I look forward to reading from you! ^^

Thank you again!

@namanbiyani
Copy link
Contributor

Yes I enjoyed it , this was my first contribution in github . Please send me notifications of resolving bugs later also if possible.

@adrienjoly
Copy link
Member Author

Congratulations for your first open-source contribution and thank you for having chosen Openwhyd! 🎉

When would you be available to resolving bugs?

@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Dec 31, 2018
@adrienjoly
Copy link
Member Author

adrienjoly commented Jan 5, 2019

Hello again, @namanbiyani ! How are you?

If you are interested in fixing other bugs, here are a few ones that are a bit more complicated but for which a fix would be very appreciated by the community:

Would you like to have a look? I'm happy to reply to your questions and provide assistance if needed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development
  
🌲 In production
Development

No branches or pull requests

2 participants