Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replaced old logo and adjusted css styling #184

Closed
wants to merge 2 commits into from
Closed

replaced old logo and adjusted css styling #184

wants to merge 2 commits into from

Conversation

namanbiyani
Copy link
Contributor

@namanbiyani namanbiyani commented Dec 26, 2018

replaced whyd logo by openwhyd logo and adjusted the css styling

@adrienjoly
Copy link
Member

adrienjoly commented Dec 26, 2018

Hi! Thank you so much for your pull request!

While testing your changes on my development laptop (using Google Chrome), I saw that the logo is not displayed in its entirety.

screen shot 2018-12-26 at 23 57 48

Do you observe the same behaviour on your end?

Ideally, I believe that the logo should be fully visible (without cropping), and aligned to the right border of the embed player, with a margin similar to the one between the left border and the first button.

Let me know if I can further assist you.

@namanbiyani
Copy link
Contributor Author

I am not being able to view my changes in the local account of openwhyd which i made using the steps of install file . please can u help in this a bit

@adrienjoly
Copy link
Member

adrienjoly commented Dec 27, 2018

Sure! In #183 (comment), I had provided you a list of steps. Can you tell me what step did not work as expected?

And, if you were not able to achieve step 1 (setup), can you also tell what operating system you're using, what command did not work, and what output / response / error message did you get ?

@namanbiyani
Copy link
Contributor Author

namanbiyani commented Dec 27, 2018

I am using Ubuntu .All commands are working but the local server using docker commands is not showing the changes in code which I had made . Even after changing logo and CSS adjustments , it is showing the previous things

@adrienjoly
Copy link
Member

Oh ok! Can you try

docker-compose restart web

... And then refresh the http://localhost:8080 page from your web browser?

adrienjoly added a commit that referenced this pull request Dec 27, 2018
@adrienjoly
Copy link
Member

Closing this PR, to be replaced by PR #185.

@adrienjoly adrienjoly closed this Dec 27, 2018
adrienjoly pushed a commit that referenced this pull request Dec 27, 2018
## [1.4.6](v1.4.5...v1.4.6) (2018-12-27)

### Bug Fixes

* **embed:** replace old logo and adjust css styling ([c3865ce](c3865ce)), closes [#183](#183) [#184](#184) [#185](#185)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants