Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UX BUG: resizing the pages scrolls to the top #20

Closed
adrienjoly opened this issue Oct 1, 2016 · 5 comments · Fixed by #303
Closed

UX BUG: resizing the pages scrolls to the top #20

adrienjoly opened this issue Oct 1, 2016 · 5 comments · Fixed by #303
Labels
bug waiting for reply
Projects
Development

Comments

@adrienjoly
Copy link
Member

adrienjoly commented Oct 1, 2016 •
edited

https://twitter.com/StevenJeuris/status/782203830280851456:

Resizing @open_whyd window scrolls page all the way to the top. Annoying in long playlists. Also triggered by search in Edge. #hcifail
@adrienjoly adrienjoly added the bug label Oct 1, 2016
@adrienjoly
Copy link
Member Author

@damienromito coucou!

rien de grave ni urgent, mais je voulais savoir si je pouvais retirer cette ligne de code: https://github.com/whyd/whyd/blame/master/whydJS/public/js/whyd.js#L34

vu que c'est toi qui l'avais ajoutée, je me demande si tu avais une bonne raison pour qu'elle y reste, ou pas.

merci d'avance pour ta réponse!

@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development Mar 25, 2017
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ⚡️To Do Next in Development Nov 26, 2019
@adrienjoly adrienjoly mentioned this issue Mar 15, 2020
Merged
@compiuta compiuta mentioned this issue Mar 22, 2020
Merged
@compiuta
Copy link
Contributor

@adrienjoly je décider de retiré cette ligne de code pour retiré le bug 😄

@adrienjoly
Copy link
Member Author

Je savais pas que tu parlais français, @compiuta ! Du coup, est-ce qu'on s'est déjà rencontrés ?

@compiuta
Copy link
Contributor

Je ne parle pas français trop bien mais je parle espagnol et je besoin de practique beucoup plus me français 😁

Nunca nos hemos encontrado en persona

@adrienjoly
Copy link
Member Author

@compiuta ¡tu francés es mejor que mi español! Estoy encantado de conocerte! :-)

(thank you, google translate, ahah!)

Development automation moved this from ⚡️To Do Next to ✔️ Done / pending QA Mar 23, 2020
adrienjoly pushed a commit that referenced this issue Mar 23, 2020
@compiuta
fix(ui): Resizing the page should not scroll to the top (#303)
1e43e68 
Closes #20.

## What does this PR do / solve?
When a user resizes the window the page has an undesired effect of scrolling to the top.

## Overview of changes
I removed the resizeWindow function and the jquery window resize event binding utilizing this function.

## How to test this PR?

When scrolling to the bottom of any page and then resizing the window we no longer have the effect of scrolling to the top automatically
adrienjoly pushed a commit that referenced this issue Mar 23, 2020
@semantic-release-bot
chore(release): 1.30.6 [skip ci]
030e023 
## [1.30.6](v1.30.5...v1.30.6) (2020-03-23)

### Bug Fixes

* **ui:** Resizing the page should not scroll to the top ([#303](#303)) ([1e43e68](1e43e68)), closes [#20](#20)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug waiting for reply
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bug): resizing the pages scrolls to the top compiuta/openwhyd
2 participants
@adrienjoly @compiuta