fix(refact): extract "sidebox" announcements into dedicated template #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adrienjoly
added a commit
that referenced
this pull request
Mar 1, 2020
…#270) Closes #269. Fixes a regression introduced in https://github.com/openwhyd/openwhyd/pull/263/files#diff-d04a3fa73a7dd2a179772cc75555275eR109: a Hogan/Mustache template became invalid after prettier processed it on save.
adrienjoly
pushed a commit
that referenced
this pull request
Mar 1, 2020
## [1.21.3](v1.21.2...v1.21.3) (2020-03-01) ### Bug Fixes * **#269:** invalid template caused crash when adding from bookmarklet ([#270](#270)) ([b8a6bb3](b8a6bb3)), closes [#269](#269) [#269](#269) [/github.com//pull/263/files#diff-d04a3fa73a7dd2a179772cc75555275eR109](https://github.com//github.com/openwhyd/openwhyd/pull/263/files/issues/diff-d04a3fa73a7dd2a179772cc75555275eR109)
adrienjoly
pushed a commit
that referenced
this pull request
Mar 1, 2020
## [1.21.4](v1.21.3...v1.21.4) (2020-03-01) ### Bug Fixes * **refact:** extract "sidebox" announcements into dedicated template ([#269](#269)) ([9dc5f33](9dc5f33))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tidy up our home/feed template by extracting the "sidebox" (top-right box used for announcements) into a separate template.