Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bookmarklet): [refactor] move browser-only code to end #286

Merged
merged 2 commits into from
Mar 13, 2020
Merged

fix(bookmarklet): [refactor] move browser-only code to end #286

merged 2 commits into from
Mar 13, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Mar 13, 2020 •
edited
Loading

Contributes to #262.

The goal is to make the bookmarklet easier to read, understand and maintain.

@adrienjoly adrienjoly self-assigned this Mar 13, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Mar 13, 2020
@adrienjoly adrienjoly merged commit dd1c58b into master Mar 13, 2020
Development automation moved this from 📥 Inbox / ideas to ✔️ Done / pending QA Mar 13, 2020
@adrienjoly adrienjoly deleted the refactor/bookmarklet-2 branch March 13, 2020 11:24
adrienjoly pushed a commit that referenced this pull request Mar 13, 2020
@semantic-release-bot
chore(release): 1.27.2 [skip ci]
c0fe551 
## [1.27.2](v1.27.1...v1.27.2) (2020-03-13)

### Bug Fixes

* **bookmarklet:** [refactor] move browser-only code to end ([#286](#286)) ([dd1c58b](dd1c58b)), closes [#262](#262)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 13, 2020
@adrienjoly adrienjoly moved this from 🌲 In production to ✔️ Done / pending QA in Development Mar 13, 2020
@adrienjoly adrienjoly mentioned this pull request Mar 13, 2020
Merged
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly