"Add" button not working when trying to add a track

[adrienjoly]

Describe the bug

"Add" button not working when trying to add a track.
Nothing happens, except the following errors in the javascript console:

sddefault.jpg:1 Failed to load resource: the server responded with a status of 404 ()

content.googleapis.com/youtube/v3/videos?id=-7t5KPGWG5w&part=snippet%2CcontentDetails%2Cstatistics&key=AIzaSyADm2ekf-_KONB3cSGm1fnuPSXx3br4fvI:1 Failed to load resource: the server responded with a status of 403 ()

playem-min.js?1.21.0:2 Uncaught TypeError: Cannot read property 'map' of undefined
    at playem-min.js?1.21.0:2
    at cb=gapi.loaded_0:852
    at cb=gapi.loaded_0:847
    at cb=gapi.loaded_0:834
    at Object.<anonymous> (cb=gapi.loaded_0:288)
    at Object.u.__cb (cb=gapi.loaded_0:206)
    at d (cb=gapi.loaded_0:200)
    at b (cb=gapi.loaded_0:195)

353021defce7f130258020ba3:1 Unchecked runtime.lastError: The message port closed before a response was received.

To Reproduce

Steps to reproduce the behavior:

1. type "test" in the search bar
2. click on the first result
3. click the "add" link below the video
4. click on the "add" button

Expected behavior

The track should be added, and the "add" dialog disappear.

Screenshots

Platforms:

• web: openwhyd.org thru Google Chrome
• desktop app

Additional context

Reported by Monstance (https://www.facebook.com/openwhyd/inbox/?notif_id=1582581798335905&notif_t=page_message_reminder&mailbox_id=1156477841040143&selected_item_id=828895359)

Could be related to the fact that our YouTube API key was shutdown by Google.

[adrienjoly]

Davy (https://www.facebook.com/openwhyd/inbox/?mailbox_id=1156477841040143&selected_item_id=1690425813) also reported that the Chrome extension does not work anymore, probably for the same reason.

[adrienjoly]

Related to #190 and #192.

Indeed, our historic YouTube API key (project number 245586658357) was disabled by Google on February 20th, 2020. (on my birthday, that's not a very nice present...)

I'm currently creating new YouTube API keys, one per file where the old one was mentionned, so I can track how many calls and sent thru each of them, from Google APIs Console.

[adrienjoly]

Note: it seems that new API keys take some time to be active. Until then, API calls (e.g. from http://localhost:8080/search?q=/yt/aZT8VlTV1YY) fail with status 403:

{
error: {
errors: [
{
domain: "usageLimits",
reason: "accessNotConfigured",
message: "Access Not Configured. YouTube Data API has not been used in project 345430738996 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=345430738996 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry.",
extendedHelp: "https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=345430738996"
}
],
code: 403,
message: "Access Not Configured. YouTube Data API has not been used in project 345430738996 before or it is disabled. Enable it by visiting https://console.developers.google.com/apis/api/youtube.googleapis.com/overview?project=345430738996 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry."
}
}

[adrienjoly]

News: here are some stats of how the different Youtube API keys have been used since yesterday (#264)

The bookmarklet (i.e. Chrome Extension) is the what consumes the most quota.

As it makes our new Google Project over-quota, I'm opening a new one just for this.

[adrienjoly]

We greatly reduced the usage of YouTube API, notably by making the boomarklet extract track info from the DOM (see PR #285) => closing. (at least for now)

[adrienjoly]

News about YouTube API Quotas

We've reduced our number of google projects to just 3:

• API keys of openwhyd-2 are restricted for calls made from openwhyd.org
• API keys of openwhyd-dev are restricted for calls made from localhost and CI
• API keys of openwhyd-6 are restricted for calls made from our remote player

The restriction of API keys and merging of google projects is still fresh (i.e. yesterday and the day before), but quota usage looks better, so far:

• prod:

• dev:

[adrienjoly]

Confirmed: quota usage has been much better since I put domain restrictions into place:

[adrienjoly]

As reported by Tut Tut, we've gone over-quota again since yesterday:

Most requested endpoints:

Usage per API key:

[adrienjoly]

Observations:

• Usage of content_embed and snip.tests keys correlate with calls to commentThreads.list, although openwhys normally does not use that endpoing

=> hypothesis: these keys may have leaked and are being used by an authorized third party

[adrienjoly]

=> I restricted both keys so that we can only be used by our production openwhyd instance.

[adrienjoly]

The restriction seems to have been successful, so far:

Let's see what it looks like, during next weekend.

[adrienjoly]

Note: on November 3rd, 2020, I received the following email from YouTube:

Access to YouTube API Services disabled due to inactivity

We've identified you as an owner or creator of one or more Google Cloud Platform projects which have been granted access to the YouTube API Services. The following projects have not accessed the Services in more than 90 days, and their API quota has been revoked in accordance with the Terms of Service.
Project openwhyd-dev (962082510392)
If you plan to resume use of the Services, you can request quota using the form linked below. REQUEST QUOTA

Which is weird because:

• Google API dashboard shows some activity on October 10th, October 27th and November 1st (https://console.cloud.google.com/apis/dashboard?project=openwhyd-dev) => I don't see a 90-day period of inactivity
• the APIs keys seem to still be active (https://console.cloud.google.com/apis/credentials?project=openwhyd-dev)
• on November 1st, I had merged PR fix(tests): Workaround "quota exceeded" errors from YouTube API #374 specifically because YouTube API was returning quota-exceeded errors when trying to run openwhyd's automated tests. They had probably already cancelled the quota by that date.