Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci): Add version as tag, when publishing on Docker Hub #306

Merged
merged 3 commits into from
Mar 28, 2020
Merged

feat(ci): Add version as tag, when publishing on Docker Hub #306

merged 3 commits into from
Mar 28, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Mar 22, 2020 •
edited
Loading

So far, we've been publishing images to Docker Hub systematically with the latest tag. This means that we overwrite the previous version of the image everytime, instead of allowing users to download a specific version of the Openwhyd docker image.

This PR should create a dedicated tag for each version.

Tests / open questions

Before doing so, can anyone make sure that we're not leaking anythink that we may regret later? (e.g. secrets)

@adrienjoly
feat(ci): add version as tag, when publishing on docker hub
3d1b21d
@adrienjoly
Merge branch 'master' into feat/ci-add-tag-on-docker-hub
41d624b 
* master: (64 commits)
  chore(release): 1.30.6 [skip ci]
  fix(ui): Resizing the page should not scroll to the top (#303)
  chore(release): 1.30.5 [skip ci]
  fix(tests): Migrate acceptance tests from Webdriver to Cypress (#301)
  chore(release): 1.30.4 [skip ci]
  fix(tests): create dummy posts from cypress tests instead of from initdb_testing (#304)
  chore(release): 1.30.3 [skip ci]
  fix(tests): Reset database between each Cypress tests (#302)
  chore(release): 1.30.2 [skip ci]
  fix(ui): Display correct track error message when using electron app (#294)
  chore(release): 1.30.1 [skip ci]
  fix(error): 404 redirect when clicking load more on account stream (#296)
  test(#295): add non-regression test for pagination (#299)
  chore(release): 1.30.0 [skip ci]
  feat(ci): separate ci tasks for each type of tests (#298)
  chore(release): 1.29.0 [skip ci]
  feat(ci): enable TypeScript in Cypress tests (#297)
  remove browser cache hack preventing css from displaying correct logo (#293)
  chore(release): 1.28.2 [skip ci]
  fix(ui): never-ending loading animation on empty search (#260)
  ...

# Conflicts:
#	.github/workflows/nodejs.yml
@adrienjoly adrienjoly marked this pull request as ready for review March 23, 2020 17:31
@adrienjoly adrienjoly requested a review from Djiit March 23, 2020 17:33
@adrienjoly adrienjoly self-assigned this Mar 23, 2020
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Mar 23, 2020
@adrienjoly adrienjoly moved this from 📥 Inbox / ideas to ⚙ In progress in Development Mar 23, 2020
@adrienjoly adrienjoly changed the title feat(ci): add version as tag, when publishing on docker hub feat(ci): Add version as tag, when publishing on Docker Hub Mar 23, 2020
@Djiit
Copy link
Member

Djiit commented Mar 24, 2020

👋 hi !
I'm not familiar with this particular action but so far the doc is clear (https://github.com/marketplace/actions/publish-docker-action#auto-tag) so we can go with this !

@Djiit
Copy link
Member

Djiit commented Mar 24, 2020

Regarsing secrets, I need to have a deeper look into the code. I'll let you know today when I have time for this.

Cheers

@adrienjoly
Copy link
Member Author

Yo @Djiit, thank you so much for the reply, and for the offer to help!

I'm not experienced with publishing docker images publicly (and probably not as experienced as you with Docker), so I'd love to feel more confident about not leaking secrets over there ^^

First things that come to mind, if that's any help about where to look first:

Do you think you could have a look?

@Djiit
Copy link
Member

Djiit commented Mar 26, 2020

Hey,

I didnt find any secrets after a quick search. Algolia Key is public anyway so it's ok to share it in the code; but you could remove it to be more strict.

The secrets suggested by your link are stored into the docker container in charge of build your docker (sic) image. No worries !

@Djiit
Copy link
Member

Djiit commented Mar 26, 2020

What you can do is a quick tour of the built image env.

build this image locally, then run sh on it (docker run -it <imagename> sh) and try to print the env with env : do you see anything strange ? try to list file in the current dir: same question ?

And you will be good to go !

@adrienjoly
Copy link
Member Author

Thanks for your reply and suggestions, @Djiit, that's very reassuring and helping for me! 😌

I'll do a quick tour, as you suggested, and hope to merge this before the end of the weekend! 💪

Au plaisir, Julien !

@adrienjoly adrienjoly mentioned this pull request Mar 28, 2020
Merged
adrienjoly added a commit that referenced this pull request Mar 28, 2020
@adrienjoly
feat(ci): prevent regressions on our Docker image (#308)
c927534 
Before applying improvements recommended in [Docker and Node.js Best Practices from Bret Fisher at DockerCon - YouTube](https://www.youtube.com/watch?v=Zgx0o8QjJk4), let's prevent regressions on our Docker image by regularly running our tests against it.

=> GitHub Actions should run a "Docker" workflow on every pull request.

Proposed next step: merge PR #306, to see the history of releases in Docker Hub.
adrienjoly pushed a commit that referenced this pull request Mar 28, 2020
@semantic-release-bot
chore(release): 1.32.0 [skip ci]
3fb7f94 
# [1.32.0](v1.31.0...v1.32.0) (2020-03-28)

### Features

* **ci:** prevent regressions on our Docker image ([#308](#308)) ([c927534](c927534)), closes [#306](#306)
@adrienjoly
Copy link
Member Author

adrienjoly commented Mar 28, 2020 •
edited
Loading

I found no secrets while exploring the image using docker-compose exec web sh. => Going to merge this PR.

Next step: try to reduce the size of the published images. (#309)

Thanks again for your help, Julien!

EDIT: Souvenir of what our docker hub profile looks like before merging this PR:

image

  • v1.32 = 391.49 MB
  • v1.33.2 = 391.44 MB

@adrienjoly adrienjoly merged commit dca5597 into master Mar 28, 2020
Development automation moved this from ⚙ In progress to ✔️ Done / pending QA Mar 28, 2020
@adrienjoly adrienjoly deleted the feat/ci-add-tag-on-docker-hub branch March 28, 2020 18:29
This was referenced Mar 28, 2020
Closed
Merged
adrienjoly pushed a commit that referenced this pull request Mar 28, 2020
@semantic-release-bot
chore(release): 1.33.0 [skip ci]
2855743 
# [1.33.0](v1.32.0...v1.33.0) (2020-03-28)

### Features

* **ci:** add version as tag, when publishing on Docker Hub ([#306](#306)) ([dca5597](dca5597))
@adrienjoly adrienjoly mentioned this pull request Mar 28, 2020
Closed
adrienjoly added a commit that referenced this pull request Mar 28, 2020
@adrienjoly
fix(docker): ignore log files (#311)
5b83c07 
Contributes to #309.

Log files were found while checking the contents of our Docker image, in PR #306. => Let's ignore them.
adrienjoly pushed a commit that referenced this pull request Mar 28, 2020
@semantic-release-bot
chore(release): 1.33.1 [skip ci]
ecc88f3 
## [1.33.1](v1.33.0...v1.33.1) (2020-03-28)

### Bug Fixes

* **docker:** ignore log files ([#311](#311)) ([5b83c07](5b83c07)), closes [#309](#309) [#306](#306)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Mar 28, 2020
@adrienjoly adrienjoly mentioned this pull request Apr 5, 2020
Merged
adrienjoly added a commit that referenced this pull request Apr 5, 2020
@adrienjoly
fix(release): attempt to publish tags on docker hub (#320)
bc64ec0 
Follow up for PR #306, based on suggestions from jerray/publish-docker-action#11 (comment)
adrienjoly pushed a commit that referenced this pull request Apr 5, 2020
@semantic-release-bot
chore(release): 1.34.1 [skip ci]
0c9e9ef 
## [1.34.1](v1.34.0...v1.34.1) (2020-04-05)

### Bug Fixes

* **release:** attempt to publish tags on docker hub ([#320](#320)) ([bc64ec0](bc64ec0)), closes [#306](#306) [/github.com/jerray/publish-docker-action/issues/11#issuecomment-607077257](https://github.com//github.com/jerray/publish-docker-action/issues/11/issues/issuecomment-607077257)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Djiit Djiit Awaiting requested review from Djiit

Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adrienjoly @Djiit