-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce size of npm dependencies => reduce weight of image on docker hub #309
Labels
Comments
This was referenced Mar 28, 2020
adrienjoly
added a commit
that referenced
this issue
Mar 28, 2020
adrienjoly
pushed a commit
that referenced
this issue
Mar 28, 2020
EDIT: Souvenir of what our docker hub profile looks like before merging this PR:
|
After removing
|
adrienjoly
added a commit
that referenced
this issue
Mar 28, 2020
Contributes to #309. We identified in #309 (comment) that PlayemJS had become Openwhyd's biggest dependency (in terms of size in MBs), after getting rid of `forever`.
adrienjoly
pushed a commit
that referenced
this issue
Mar 28, 2020
## [1.33.4](v1.33.3...v1.33.4) (2020-03-28) ### Bug Fixes * **deps:** upgrade to (smaller) playemjs v0.3.1 ([#314](#314)) ([4ea4237](4ea4237)), closes [#309](#309) [/github.com//issues/309#issuecomment-605508547](https://github.com//github.com/openwhyd/openwhyd/issues/309/issues/issuecomment-605508547)
adrienjoly
added a commit
that referenced
this issue
Mar 28, 2020
Contributes to #309. Upgraded `playemjs` to a version that doesn't need `git` to install `soundmanager2` dependency. (as `git` is not installed on the `slim` version of the `node` docker image)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
E.g. by applying some changes recommended in Docker and Node.js Best Practices from Bret Fisher at DockerCon - YouTube.
From https://stackoverflow.com/questions/40642008/how-do-i-view-the-size-of-npm-packages:
The text was updated successfully, but these errors were encountered: