fix: Migrating two tests from WebDriver to Cypress #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Salayna
changed the title
|
I think that Codacy does not take our Eslint/prettier configuration into account, because both => I'm going to disable that rule on the Codacy side. |
|
I just found that Prettier 2.0 made some important formatting changes:
=> Hypothesis: Codacy is ignoring our version of Prettier, and applying Prettier 2.0's rules. => Trying to upgrade to latest version and reformat all files: #341 |
adrienjoly
pushed a commit
that referenced
this pull request
Aug 25, 2020
## [1.34.9](v1.34.8...v1.34.9) (2020-08-25) ### Bug Fixes * **tests:** Migrate 2 tests from Webdriver to Cypress ([#335](#335)) ([36451d9](36451d9))
adrienjoly
added a commit
that referenced
this pull request
Aug 27, 2020
... for alignment with Codacy's rules. cf #335 (comment) e.g. https://app.codacy.com/gh/openwhyd/openwhyd/pullRequest?prid=6070209
adrienjoly
pushed a commit
that referenced
this pull request
Aug 27, 2020
## [1.34.11](v1.34.10...v1.34.11) (2020-08-27) ### Bug Fixes * **deps:** Update ESLint and Prettier + plugins ([#341](#341)) ([b8c7728](b8c7728)), closes [/github.com//pull/335#issuecomment-680291284](https://github.com//github.com/openwhyd/openwhyd/pull/335/issues/issuecomment-680291284)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #199
What does this PR do / solve?
Migrating two tests from WebDriver to Cypress