-
-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Migrating two tests from WebDriver to Cypress #335
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Good job, Salayna! 💪
I think that Codacy does not take our Eslint/prettier configuration into account, because both => I'm going to disable that rule on the Codacy side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I just found that Prettier 2.0 made some important formatting changes:
=> Hypothesis: Codacy is ignoring our version of Prettier, and applying Prettier 2.0's rules. => Trying to upgrade to latest version and reformat all files: #341 |
## [1.34.9](v1.34.8...v1.34.9) (2020-08-25) ### Bug Fixes * **tests:** Migrate 2 tests from Webdriver to Cypress ([#335](#335)) ([36451d9](36451d9))
... for alignment with Codacy's rules. cf #335 (comment) e.g. https://app.codacy.com/gh/openwhyd/openwhyd/pullRequest?prid=6070209
## [1.34.11](v1.34.10...v1.34.11) (2020-08-27) ### Bug Fixes * **deps:** Update ESLint and Prettier + plugins ([#341](#341)) ([b8c7728](b8c7728)), closes [/github.com//pull/335#issuecomment-680291284](https://github.com//github.com/openwhyd/openwhyd/pull/335/issues/issuecomment-680291284)
Closes #199
What does this PR do / solve?
Migrating two tests from WebDriver to Cypress