Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sort playlist feature #372

Merged
merged 4 commits into from
Nov 1, 2020

Conversation

compiuta
Copy link
Contributor

Closes #371

What does this PR do / solve?

Add playlist sort feature that includes an alphabetized option

Overview of changes

added sort menu to the playlist header with a sort by date option and an alphabetized option

sort-menu-initial

sort-menu-hover-alphabetized

How to test this PR?

Use the profile side nav and click on the playlist menu item. On the playlist page you will now have a sort menu next to the playlist main header.

Let me know if there are any changes needed 😃

@compiuta compiuta changed the title Add sort playlist feature feat: Add sort playlist feature Oct 27, 2020
@adrienjoly
Copy link
Member

Thank you for your PR, @compiuta !

Can you run npm run lint:fix to fix the formatting errors reported by Codacy?

@compiuta
Copy link
Contributor Author

@adrienjoly

Alright looks like that fixed the issue 🎉

Copy link
Member

@adrienjoly adrienjoly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job! Thank you for your contributions!

@adrienjoly adrienjoly merged commit 9ce65ac into openwhyd:master Nov 1, 2020
adrienjoly pushed a commit that referenced this pull request Nov 1, 2020
# [1.36.0](v1.35.3...v1.36.0) (2020-11-01)

### Bug Fixes

* **tests:** Workaround "quota exceeded" errors from YouTube API ([#374](#374)) ([53807af](53807af))

### Features

* Add alphabetical order to playlists page ([#372](#372)) ([9ce65ac](9ce65ac)), closes [#371](#371)
@compiuta compiuta deleted the add-sort-playlist-feature branch November 1, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alphabetise/sort lists of playlists
2 participants