Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bookmarklet): Split bookmarklet.js into separate TypeScript files #384

Merged
merged 16 commits into from
Nov 8, 2020
Merged

fix(bookmarklet): Split bookmarklet.js into separate TypeScript files #384

merged 16 commits into from
Nov 8, 2020

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Nov 8, 2020 •
edited
Loading

Contributes to #381.

Step 1 of the refactoring: convert bookmarklet.js into separate TypeScript files and fix easy issues.

@adrienjoly adrienjoly changed the title fix linter errors Refactor the bookmarklet Nov 8, 2020
@adrienjoly adrienjoly changed the title Refactor the bookmarklet fix(bookmarklet): Refactor the bookmarklet Nov 8, 2020
@adrienjoly adrienjoly changed the title fix(bookmarklet): Refactor the bookmarklet fix(bookmarklet): Split bookmarklet.js into separate TypeScript files Nov 8, 2020
@adrienjoly adrienjoly self-assigned this Nov 8, 2020
@adrienjoly adrienjoly marked this pull request as ready for review November 8, 2020 17:27
@adrienjoly adrienjoly mentioned this pull request Nov 8, 2020
Open
6 tasks
@adrienjoly adrienjoly added this to 📥 Inbox / ideas in Development via automation Nov 8, 2020
@adrienjoly adrienjoly merged commit a1d03dc into master Nov 8, 2020
Development automation moved this from 📥 Inbox / ideas to ✔️ Done / pending QA Nov 8, 2020
@adrienjoly adrienjoly deleted the fix/refactor-bookmarklet branch November 8, 2020 17:33
adrienjoly pushed a commit that referenced this pull request Nov 8, 2020
@semantic-release-bot
chore(release): 1.37.5 [skip ci]
89f5395 
## [1.37.5](v1.37.4...v1.37.5) (2020-11-08)

### Bug Fixes

* **bookmarklet:** Split bookmarklet.js into separate TypeScript files ([#384](#384)) ([a1d03dc](a1d03dc)), closes [#381](#381)
@adrienjoly adrienjoly moved this from ✔️ Done / pending QA to 🌲 In production in Development Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@adrienjoly adrienjoly

Labels
enhancement
Projects
Development
  
🌲 In production
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adrienjoly