Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bookmarklet): Split bookmarklet.js into separate TypeScript files #384

Merged
merged 16 commits into from
Nov 8, 2020
Merged

fix(bookmarklet): Split bookmarklet.js into separate TypeScript files #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
da9072d
fix linter errors
adrienjoly Nov 8, 2020
76d3faf
fix linter issues in test
adrienjoly Nov 8, 2020
757da17
fix cypress tests
adrienjoly Nov 8, 2020
32494a7
fix: bookmarklet does not rely on UI to count tracks
adrienjoly Nov 8, 2020
24c2baf
fix:lint
adrienjoly Nov 8, 2020
9fb5604
convert bookmarklet to TypeScript
adrienjoly Nov 8, 2020
017b540
$ npx tsc public/js/bookmarklet.ts; npx prettier public/js/bookmarkle…
adrienjoly Nov 8, 2020
9b930f5
obvious TS fixes
adrienjoly Nov 8, 2020
db446ac
simple TS fixes
adrienjoly Nov 8, 2020
3714f80
test: File detector should return the default cover art with right pr…
adrienjoly Nov 8, 2020
8b12097
✅ makeBookmarklet() takes no params anymore
adrienjoly Nov 8, 2020
153db61
split bookmarklet.ts into bookmarkletLogic.ts and boomarkletUI.ts
adrienjoly Nov 8, 2020
e158d12
fix: run all tests
adrienjoly Nov 8, 2020
00a34e3
extract YOUTUBE_PLAYER as openwhydYouTubeExtractor, in its own TS file
adrienjoly Nov 8, 2020
a92785f
add scripts/transpile-bookmarklet.sh
adrienjoly Nov 8, 2020
7fa0a87
fix(codacy): https://app.codacy.com/gh/openwhyd/openwhyd/file/5001150…
adrienjoly Nov 8, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ More generally, make sure to follow these three principles:
- **config** Database initialization scripts, http routes, and other configuration files
- **cypress** End-to-End tests
- **docs** API documentation and other references documents
- **misc** Code of browser extension
- **public** Frontend assets: images, css, js files
- **misc** Code of browser extension
- **public** Frontend assets: images, css, js files
- **scripts** Utilities for production and data analatics
- **test** Integration and unit tests

Expand Down
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"url": "https://github.com/openwhyd/openwhyd.git"
},
"scripts": {
"build:bookmarklet": "scripts/transpile-bookmarklet.sh",
"doc:serve": "cd docs && gem install bundler && bundle install && bundle exec jekyll serve --incremental",
"semantic-release": "semantic-release",
"contributors:add": "all-contributors add",
Expand Down
Loading