Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): Paste a YouTube / Soundcloud / Bandcamp / Deezer / MP3 track URL here #461

Merged
merged 3 commits into from
May 28, 2021

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented May 27, 2021

What does this PR do / solve?

Despite it being the main task done by Openwhyd.org users, adding a track is not obvious to do for new users.

Also, the placeholder text of our search bar ("Search for a song, artist, genre...") may let new users think that they can search for any track on earth, which is not the case: it just searches for tracks already posted on Openwhyd. Which can be a deceptive experience.

The solution proposed by this PR is to make it clearer to new users that they can paste a URL there to add a track.

Before changes

image

Overview of changes

image

@adrienjoly adrienjoly marked this pull request as ready for review May 28, 2021 17:12
@adrienjoly adrienjoly self-assigned this May 28, 2021
@adrienjoly adrienjoly merged commit c8be106 into master May 28, 2021
@adrienjoly adrienjoly deleted the fix/ui-searchbar-paste-url branch May 28, 2021 17:13
@adrienjoly
Copy link
Member Author

Contributes to #414 and #188.

adrienjoly pushed a commit that referenced this pull request May 28, 2021
## [1.44.43](v1.44.42...v1.44.43) (2021-05-28)

### Bug Fixes

* **ui:** Improve text of search bar placeholder for new users ([#461](#461)) ([c8be106](c8be106))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant