Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cypress): prevent browserVersion mismatch #618

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

adrienjoly
Copy link
Member

@adrienjoly adrienjoly commented Jul 18, 2023

What does this PR do / solve?

Cf https://github.com/openwhyd/openwhyd/actions/runs/5587330707/jobs/10212532677#step:8:125:

You passed the --parallel flag, but we do not parallelize tests across different environments.

This machine is sending different environment parameters than the first machine that started this parallel run.

The existing run is: https://cloud.cypress.io/projects/8mw8bh/runs

In order to run in parallel mode each machine must send identical environment parameters such as:

 - specs
 - osName
 - osVersion
 - browserName
 - browserVersion (major)

This machine sent the following parameters:

{
  "osName": "linux",
  "osVersion": "Ubuntu - ",
  "browserName": "Chromium",
  "browserVersion": "113.0.5672.0.... (Expected: 114)",
  "specs": [
    "cypress/e2e/acceptance.spec.ts",
    "cypress/e2e/bookmarklet.spec.ts",
    "cypress/e2e/email-notification.spec.ts",
    "cypress/e2e/playback.spec.ts",
    "cypress/e2e/stream.spec.ts",
    "cypress/e2e/upload.spec.ts",
    "cypress/e2e/visual-snapshots.ts"
  ]
}

https://on.cypress.io/parallel-group-params-mismatch

Overview of changes

Solution: cypress-io/github-action#518 (comment)

@adrienjoly adrienjoly self-assigned this Jul 18, 2023
@adrienjoly adrienjoly added the bug label Jul 18, 2023
@adrienjoly adrienjoly marked this pull request as ready for review July 18, 2023 12:30
@cypress
Copy link

cypress bot commented Jul 18, 2023

Passing run #916 ↗︎

0 26 1 0 Flakiness 0

Details:

Merge d11f70a into 6d8eca8...
Project: Openwhyd Commit: 2cccf9eaf3 ℹ️
Status: Passed Duration: 02:54 💡
Started: Jul 18, 2023 12:30 PM Ended: Jul 18, 2023 12:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@adrienjoly adrienjoly merged commit 22cbb0b into main Jul 18, 2023
17 checks passed
@adrienjoly adrienjoly deleted the fix/cypress-browser-version-mismatch branch July 18, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant